Closed Bug 578785 Opened 14 years ago Closed 14 years ago

Animate notification bar sliding with CSS transitions instead of JS

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
status2.0 --- wanted

People

(Reporter: johnath, Assigned: dao)

References

Details

Attachments

(1 file, 3 obsolete files)

This ought to be a dup, but I can't find one. The notification bar slide-in/-out has often been chunky, but we did what we had to to get the effect we wanted. Now we have CSS transitions that ought to take a lot of this out of XBL. I suspect it might also make things smoother. I'm certain it will substantially simplify notification.xml. Is there any reason not to do this?
Version: 1.9.2 Branch → Trunk
Attached patch wip (obsolete) (deleted) — Splinter Review
This works, but has this slightly ugly hack: newitem.style.marginTop = "-50px"; I couldn't get the actual height of the notification bar without screwing up the transition. It simplifies the code somewhat but not greatly. It does feel smoother.
Attached patch wip (obsolete) (deleted) — Splinter Review
minor cleanup
Attachment #457420 - Attachment is obsolete: true
Attached patch patch (deleted) — Splinter Review
It's not critical for the initial negative margin to match the real height -- what's mostly relevant is that the transition ends smoothly.
Assignee: nobody → dao
Attachment #457422 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #457526 - Flags: review?(enndeakin)
Attached image screenshot of problem (obsolete) (deleted) —
When I run test_notification.xul with this patch, I get drawing problems as the notifications appear. None of the notifications are in colour and the text appears to overlap each other. Possibly, an issue with transparency.
Attachment #457526 - Flags: review?(enndeakin) → review-
-moz-transition is currently broken. (It wasn't when I wrote the patch.)
Depends on: 579323
Attachment #457526 - Flags: review- → review?(enndeakin)
Attachment #459106 - Attachment is obsolete: true
Attachment #457526 - Flags: review?(enndeakin) → review+
Attachment #457526 - Flags: approval2.0?
Attachment #457526 - Flags: approval2.0? → approval2.0+
Depends on: 596522
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: