Closed
Bug 578786
Opened 14 years ago
Closed 14 years ago
Reftests 491180-1.html & 491180-2.html fail on Ubuntu 10.04 (gray vs black text)
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The reftests 491180-1.html & 491180-2.html fail locally on my desktop (running Ubuntu 10.10a2) and my laptop (running Ubuntu 10.04), with the default Ubuntu theme.
In both test cases, the text is a shade of gray, while both reference cases have black text.
Adding 'color: black' to the <button>'s style in the testcases seems to fix the problem.
|
Assignee | |
Comment 1•14 years ago
|
||
here's the reftest log (suitable for passing to http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml )
|
|
Assignee | |
Comment 2•14 years ago
|
||
Trivial fix -- just add color:black to the tests, as noted in previous comment. (Presumably the button/input text-color is controlled by the system theme, if it's not explicitly specified.)
This also removes a non-functional/unmatched closing "</div>" tag from each test -- looks like those were just copy-paste cruft from the reference cases (which actually use <div>'s).
|
||
Comment 3•14 years ago
|
||
Comment on attachment 457387 [details] [diff] [review]
trivial fix
r=me. Sorry for the lag. :(
Attachment #457387 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
No problem -- thanks for the r+!
Landed:
http://hg.mozilla.org/mozilla-central/rev/99657ce12bdf
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•