The star button should be on the left end (or right end in rtl locales) of the location bar. Also, the favicon in the location bar is redundant, since we already show it on the selected tab, so the favicon should be removed too. This is backed up by the Firefox 4 mockups. See bug 578025 for images.

ATM the favicon's onclick displays an unuseful Larry popup when the site is not SSL-protected, so removing the favicon seems okay to me since the favicon is shown on the tab itself too. I'm commenting from my mobile phone using Opera Mini, so I can't verify if a click on the favicon really shows Larry. It could be that it shows the 'Bookmark This Page' panel, if so, we'd have duplicated behaviour which is probably bad. Anyway, I think removing the favicon is the way to go.

(In reply to comment #0) > Also, the favicon in the location bar is redundant, since we already show it on > the selected tab, so the favicon should be removed too. That favicon will have to be "cut out" from the SSL box.

Note that Chrome, which likely inspired us here, recently moved the star to right for consistency: "The bookmark star icon has joined the other “page actions” at the right-hand side of the Omnibox", http://blog.chromium.org/2010/06/fresh-coat-of-chrome.html

Hmm, I think having on the left side is more consistent. Currently we have button-adress-button and with both button related to the page it doesn't look very consistent to me.

We also have a feed button, and extensions commonly add buttons to the right end.

True, but having everything on the right will make it looks a bit cluttered, no?

Well, no, I think it looks organized. By your logic we'd have to sprinkle the icons all over the UI to make them not look cluttered.

OK, since SSL box isn't movable, why not move everything to left? In that way we would have every single button on the left side.

The URL is left-aligned; if at all, there's usually space on the right.

So we keep Star Button where it is? If so, this bug can be renamed to "Remove redundant favicon in location bar" before Frank attach patch that moves Star Button as well.

Two points regarding the favicon: - hiding the tab bar with only one tab open is currently still supported - explicitly exposing the "no identity information" case was considered important, so this needs to be discussed if you don't want to provide a replacement

(In reply to comment #11) > - explicitly exposing the "no identity information" case was considered > important, so this needs to be discussed if you don't want to provide a > replacement We can put domain's name in it's own box, which will indicate "no identity information" state and by pressing it Doorhanger notifications "no identity information" will appear.

(In reply to comment #12) > (In reply to comment #11) > > - explicitly exposing the "no identity information" case was considered > > important, so this needs to be discussed if you don't want to provide a > > replacement > > We can put domain's name in it's own box, which will indicate "no identity > information" state and by pressing it Doorhanger notifications "no identity > information" will appear. Put the domain in its own box doesn't sound too bad, but how would you invoke the popup? By clicking the domain? That doesn't work since the domain needs to be editable. If you mean that we introduce a new box with the domain in it, it isn't really useful either because this would make the domain redundant.

You could invoke editing by double-clicking on the box.

I rescoped this bug to deal only with the location bar's star button and feed button. If you wish continue discussion regarding the identity box and its favicon, please continue in a separate bug.

I'm not really sure why we want to remove the feed button, I was often asked to remove the subscribe options from menus because we had the button, that greatly helps discoverability of feeds. So what's the suggested path for feeds discoverability? If you're so worried about favicon duplication, why not hiding the favicon from current tab instead, giving also more space to the title, if the location bar is visible?

Also removing favicon will kill the possibility to drag it to desktop to make a shortcut (sure you can select all the url and drag it, but it's far more complicated)

For that is bug 578959.

Considering that the removal of the feed button is especially controversial and may or may not actually happen, I split off the star button movement to a separate bug (bug 578964), since that will almost certainly land in Firefox 4.

This bug no longer makes any sense. See bug 578967 for feed button removal.

(In reply to Dão Gottwald [:dao] from comment #5) > We also have a feed button, and extensions commonly add buttons to the right > end. Would not it be better if when the user will locate the Feed button to the right of the location bar then the Feed button will locate itself inside the location bar? (similarly to the Reload/Stop buttons) -Related to bug 578929

Realization: (1) Customize Toolbar mode (both of the images are the same) http://c25.img-up.net/?up=FF_RSS_01zwysu.png http://x66.img-up.net/?up=FF_RSS_024yqta.png (2) Result: http://q37.img-up.net/?up=FF_RSS_03zjh0q.png This would have been the right thing to do instead of hoggishly omitting the Feed indicator from the location bar.