Closed Bug 580952 Opened 14 years ago Closed 14 years ago

Expose an AllTabs module that handles tabs from all browser windows

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file, 1 obsolete file)

This module would at minimum provide a way to listen to various tab events independent of what window the tab is in. This would be useful for bug 578512 to handle tabs from all windows.
Blocks: 580954
Attached patch v1 wip (obsolete) (deleted) — Splinter Review
Early AllTabs module that isn't hooked up in any way and still has various debugging. Can be tested with Components.utils.import("resource://gre/modules/TabViewAllTabs.js");
Depends on bug 580937 as existing onFocus handlers are expecting BrowserTab objects.
Depends on: 580937
Pa(In reply to comment #1)
> Created attachment 459357 [details] [diff] [review]
> v1 wip
> 
> Early AllTabs module that isn't hooked up in any way and still has various
> debugging. Can be tested with
> Components.utils.import("resource://gre/modules/TabViewAllTabs.js");

Looking good (read, not tested).
Attached patch v1 (deleted) — Splinter Review
Assignee: nobody → edilee
Attachment #459357 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #460701 - Flags: feedback?(ian)
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/41d8af181a34
Replace the existing Tabs/TabsManager object with the Tabs module that exposes allTabs, onChange, onClose, onMove, onOpen, onSelect.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 582597
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/5bcd57aa7869
Followup to bug 580952 so that only tabs from the current window are handled.
Comment on attachment 460701 [details] [diff] [review]
v1

Looks good, thanks!
Attachment #460701 - Flags: feedback?(ian) → feedback+
Blocks: 584532
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: