Open
Bug 581275
Opened 14 years ago
Updated 2 years ago
solve the imgIRequest listener reference mess
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
NEW
People
(Reporter: joe, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Right now it's impossible to write certain tests from javascript because imgIRequest doesn't store a strong reference to its listener, so the imgIDecoderObserver that xpconnect creates out of thin air can go away at inopportune times, and with no warning.
We should either make imgRequestProxy::mListener a strong reference and cycle collect imgIDecoderObserver implementations and imgRequestProxys, or we should make imgRequestProxy::mListener an nsWeakPtr and deal with the fact that we can't depend on our listener existing for all time.
Reporter | ||
Comment 1•14 years ago
|
||
Jeff and I talked about this a while back, but I don't remember what we settled on.
OS: Mac OS X → All
Hardware: x86 → All
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•