Closed
Bug 581499
Opened 14 years ago
Closed 14 years ago
CR and LF characters in a textarea field shouldn't trigger JIS x 4051 line breaking
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b3
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
I _think_ this patch should be safe. Without this, with bug 240933, every textarea containing multiple lines would be subject to the JIS x 4051 line breaking algorithm.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #459870 -
Flags: review?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #459870 -
Flags: review? → review?(masayuki)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Can we also do this for the space character as well?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 459870 [details] [diff] [review]
Patch (v1)
I'm not a good reviewer for this, roc is better.
Attachment #459870 -
Flags: review?(masayuki) → review?(roc)
Attachment #459870 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #2)
> Can we also do this for the space character as well?
Roc: ^
|
|
Assignee | |
Updated•14 years ago
|
Attachment #459870 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #459870 -
Flags: approval2.0? → approval2.0+
We don't need to include whitespace characters here that match NS_IsSpace:
http://mxr.mozilla.org/mozilla-central/source/intl/lwbrk/public/nsILineBreaker.h#76
So in fact we only need to add 0x000A
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•