Closed
Bug 581612
Opened 14 years ago
Closed 14 years ago
Add showOnlyTheseTabs functionality to tabbrowser
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
iangilman
:
review-
iangilman
:
feedback-
|
Details | Diff | Splinter Review |
Instead of Tabbar.showOnlyTheseTabs, it can be part of tabbrowser.
Assuming bug 580847 is fixed to move the tabs to the right places, there shouldn't be a need for the current functionality of reordering tabs when showing only those tabs.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #459970 -
Flags: feedback?(ian)
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #459970 -
Attachment is obsolete: true
Attachment #459970 -
Flags: feedback?(ian)
Assignee | ||
Comment 3•14 years ago
|
||
Seems like Raymond rolled the show functionality into UIManager:
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Seems like Raymond rolled the show functionality into UIManager:
> http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/b1c26205b38b
Oh, sorry. I saw the comment 2 in bug 581267 and miss this one.
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/11493ab7c276
Move and simplify showOnlyTheseTabs functionality into tabbrowser now that there's no reordering happening on show.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Summary: Add show Tabs functionality to tabbrowser → Add showOnlyTheseTabs functionality to tabbrowser
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/430dddaaf423
Call updateTabBarForActiveGroup so that Group is correctly set for this.
Comment 7•14 years ago
|
||
Comment on attachment 459972 [details] [diff] [review]
v1
Looks good except for this line:
Utils.timeout(Groups.updateTabBarForActiveGroup, 400);
"this" won't be set up properly.
Attachment #459972 -
Flags: review-
Attachment #459972 -
Flags: feedback-
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•14 years ago
|
||
See comment 6.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 9•14 years ago
|
||
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Updated•14 years ago
|
Keywords: dev-doc-needed
Comment 10•14 years ago
|
||
Documented here:
https://developer.mozilla.org/en/XUL/Method/showOnlyTheseTabs
https://developer.mozilla.org/en/XUL/Method/showAllTabs
Added to the list of methods on tabbrowser here:
https://developer.mozilla.org/en/XUL/tabbrowser
Linked from Firefox 4 for developers.
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 11•14 years ago
|
||
sheppy, sorry for the confusion, but this bug originally landed as part of the tabcandy-central branch, and the code that landed in m-c is in bug 582116 where there ended up not being a showAllTabs.
Comment 12•14 years ago
|
||
Removed showAllTabs from the docs; thanks!
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•