Closed
Bug 581657
Opened 14 years ago
Closed 14 years ago
Async favicons fails on null data
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla2.0b4
People
(Reporter: mak, Assigned: mak)
Details
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
this can happen in some rare condition (when opening same page multiple times). the icon is set by the first call, next ones are firing useless warnings.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #460023 -
Flags: review?(sdwilsh)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 460023 [details] [diff] [review]
patch v1.0
r=sdwilsh
Attachment #460023 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 460023 [details] [diff] [review]
patch v1.0
needs approval, risk is minimum, just a null check.
Attachment #460023 -
Flags: approval2.0?
|
||
Comment 4•14 years ago
|
||
Comment on attachment 460023 [details] [diff] [review]
patch v1.0
a=beltzner
Attachment #460023 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
forgot to close
http://hg.mozilla.org/mozilla-central/rev/92a9a7c997f1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•