Closed
Bug 581909
Opened 14 years ago
Closed 14 years ago
Don't pass -safeseh to ml64 because the behaviour is buggy
Categories
(Core :: js-ctypes, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dwitte
:
review+
|
Details | Diff | Splinter Review |
ml64 -nologo -safeseh -c -Fosrc/x86/win64.obj src/x86/win64.asm
MASM : warning A4018: invalid command-line option : -safeseh Assembling: src/x86/win64.asm
Microsoft (R) Incremental Linker Version 8.00.50727.762
Copyright (C) Microsoft Corporation. All rights reserved.
/OUT:win64.exe
src/x86/win64.obj
LINK : fatal error LNK1561: entry point must be defined
For some reason ml64 ignores the -c following -safeseh and tries to link.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Comment on attachment 460215 [details] [diff] [review]
Proposed patch
r=dwitte, please also add this to js/src/ctypes/libffi.patch, and reference this bug in the description at the top. I'll push it upstream.
Attachment #460215 -
Flags: superreview+
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 460215 [details] [diff] [review]
Proposed patch
Bugzilla from a phone is hard.
Attachment #460215 -
Flags: review?(dwitte) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #460215 -
Attachment is obsolete: true
Attachment #461004 -
Flags: review?(dwitte)
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 461004 [details] [diff] [review]
Updated for review comments
r=dwitte, I'll push upstream and to tracemonkey. (No need to push to m-c.)
Attachment #461004 -
Flags: review?(dwitte) → review+
|
|
||
Comment 6•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•