(not currently active) Ted Mielczarek Reporter
	Description • 14 years ago

Now that MozillaBuild 1.5 is released and has Python 2.6, we should be able to use the pymake native-commands branch. I'd like to merge that branch to default in the pymake repo, and then update the snapshot in mozilla-central so we can start using its features in the build system.

bsmedberg, if you have time to glance over my changes (invasive though they are), that'd be helpful. If anyone has any implementation comments or suggestions that'd also be helpful. For example, I'm thinking that the implementation of native commands should probably be changed to just take one parameter, the argument list, and the PythonJob runner class should be setting the environment using os.environ instead, just to simplify command implementation.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 1 • 14 years ago

FWIW, after patching those threading issues I haven't run into any issues with the branch (been using it for a month or two now).

I don't really have any implementation comments since I don't remember what the code looks like but I'll try to take a look at some point.

	(not currently active) Ted Mielczarek Reporter
	Comment 2 • 14 years ago

I made the argument change I mentioned in comment 0:
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/120cbf584f23

	Mitchell Field [:Mitch] Assignee
	Comment 3 • 14 years ago

Merged snapshot as of here:
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/e50be3234e39

to here:
http://hg.mozilla.org/mozilla-central/rev/f2c04d62dc9c

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 4 • 14 years ago

Backed out due to perf loss.

	(not currently active) Ted Mielczarek Reporter
	Comment 5 • 14 years ago

khuey relanded this after fixing bug 602506:
http://hg.mozilla.org/mozilla-central/rev/942830bbb94c