Closed
Bug 582400
Opened 14 years ago
Closed 14 years ago
Move the Clear functionality in the Web Console to a context menu
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b5
People
(Reporter: pcwalton, Assigned: pcwalton)
References
Details
(Whiteboard: [kd4b5] [patchclean:0819])
Attachments
(3 files, 2 obsolete files)
(deleted),
patch
|
mossop
:
review+
limi
:
ui-review+
ddahl
:
feedback+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
In the Web Console, the Clear Console button takes up a large amount of screen real estate and slightly clutters the interface. It's also an infrequently-used action, especially if we have headers to help developers visually categorize their messages (bug 580400). So I suggest moving it to a context menu.
The attached patch implements this. Requesting approval for Firefox 4.
Attachment #460673 -
Flags: ui-review?(limi)
Attachment #460673 -
Flags: feedback?(ddahl)
Comment 1•14 years ago
|
||
Comment on attachment 460673 [details] [diff] [review]
Proposed patch.
Won't this make the clear functionality less discoverable?
Assignee | ||
Comment 2•14 years ago
|
||
Yes, but I think it's rare enough that the tradeoff in discoverability versus clutter reduction makes it worth it. The alternative would be to move the clear button to the bottom right.
Updated•14 years ago
|
Attachment #460673 -
Flags: feedback?(ddahl) → feedback+
Assignee | ||
Updated•14 years ago
|
Attachment #460673 -
Flags: review?(dtownsend)
Updated•14 years ago
|
Attachment #460673 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Screenshot attached.
Comment 4•14 years ago
|
||
I do like like that. nice.
Updated•14 years ago
|
Whiteboard: [kd4b3]
Updated•14 years ago
|
Whiteboard: [kd4b3] → [kd4b4]
Comment 5•14 years ago
|
||
Comment on attachment 460673 [details] [diff] [review]
Proposed patch.
I don't have strong opinions either way, but right-click is a fine way to do this — if possible, it would also be nice to support the keyboard shortcut that terminals use to do this (Ctrl/Cmd-K), but since it's already assigned to a function in FF, it might be hard to selectively override it here.
In any case, I'm fine with either approach, as long as the console can be cleared easily. :)
Attachment #460673 -
Flags: ui-review?(limi) → ui-review+
Assignee | ||
Updated•14 years ago
|
Attachment #460673 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #460673 -
Flags: approval2.0? → approval2.0+
Updated•14 years ago
|
Keywords: uiwanted → checkin-needed
Comment 6•14 years ago
|
||
this conflicts now that bug 574036 has landed. Doesn't apply cleanly.
Assignee | ||
Comment 8•14 years ago
|
||
Rebased to trunk. I'm requesting rereview because the patch is significantly different from the older iteration now that bug 574036 has landed.
Attachment #464628 -
Flags: feedback?(ddahl)
Updated•14 years ago
|
Attachment #464628 -
Flags: feedback?(ddahl) → feedback+
Assignee | ||
Updated•14 years ago
|
Attachment #464628 -
Flags: review?(dietrich)
Comment 9•14 years ago
|
||
Comment on attachment 464628 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-10).
r+a=me
Attachment #464628 -
Flags: review?(dietrich)
Attachment #464628 -
Flags: review+
Attachment #464628 -
Flags: approval2.0+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Updated•14 years ago
|
Whiteboard: [kd4b4] → [kd4b5]
Updated•14 years ago
|
Whiteboard: [kd4b5] → [kd4b5] [patchclean:0817]
Comment 10•14 years ago
|
||
rebased - problem in properties file
Attachment #464628 -
Attachment is obsolete: true
Attachment #467539 -
Flags: review+
Updated•14 years ago
|
Whiteboard: [kd4b5] [patchclean:0817] → [kd4b5] [patchclean:0819]
Updated•14 years ago
|
Keywords: checkin-needed
Comment 11•14 years ago
|
||
None of the tests run with this patch applied. perhaps I rebased it wrong?
Assignee | ||
Comment 12•14 years ago
|
||
Attachment #467539 -
Attachment is obsolete: true
Comment 13•14 years ago
|
||
after the next push we will have to rebase this again and then push it.
Comment 14•14 years ago
|
||
(In reply to comment #13)
> after the next push we will have to rebase this again and then push it.
nevermind - wrong bug.
Comment 15•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Target Milestone: --- → Firefox 4.0b5
Comment 16•14 years ago
|
||
postmortem review nit: the clear menuitem should not have buttonType="clear", but something like id="hud-clear".
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•