Closed
Bug 582455
Opened 14 years ago
Closed 14 years ago
Remove the grippy from the Web Console
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(blocking2.0 betaN+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: pcwalton, Assigned: pcwalton)
References
Details
(Whiteboard: [kd4b3])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mossop
:
review+
ddahl
:
feedback+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
The image on the grippy on the Web Console is currently overlaid on top of the knob, which looks strange on Mac and Windows. Also, the cursor changes to the "hand" cursor while over the grippy, which is, IMHO, less appropriate than the "ns-resize" cursor.
The attached patch fixes these issues. It touches only the CSS.
Because this is a serious UI issue that could confuse users, I'd like to request that it block the Firefox 4 release.
Attachment #460716 -
Flags: review?(robert.bugzilla)
Attachment #460716 -
Flags: feedback?(ddahl)
Comment 1•14 years ago
|
||
Comment on attachment 460716 [details] [diff] [review]
Proposed patch.
Sounds like you really want to just take out the grippy instead of covering up its effects. cf the (grippy-less) splitters in the Page Info dialog, the one used for the sidebars, the one in Library, etc.. Grippies aren't really used in Firefox. In fact, after a quick search on MXR, it seems grippies aren't used in mozilla-central *at all*.
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Grippies aren't really used in
> Firefox. In fact, after a quick search on MXR, it seems grippies aren't used in
> mozilla-central *at all*.
wow. who knew?
Comment 3•14 years ago
|
||
> In fact, after a quick search on MXR, it seems grippies aren't used in
> mozilla-central *at all*.
Did you check comm-central as well? :D
http://mxr.mozilla.org/comm-central/search?string=grippy&find=\.xul
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Did you check comm-central as well? :D
> http://mxr.mozilla.org/comm-central/search?string=grippy&find=\.xul
I'm aware that SeaMonkey uses them quit a bit, but the code in question is also m-c. Although, if this is going to see reuse in SeaMonkey, it might be appropriate to use a grippy and use a rule in the Firefox skin to make it "display: none;", which effectively amounts to "tak[ing] it out" there.
Comment 5•14 years ago
|
||
I'm joking. By all means take it out since Firefox will be the primary consumer. I'm sure we'll somehow manage.
Assignee | ||
Comment 6•14 years ago
|
||
New patch removes the grippy.
This causes a regression in that the splitter can no longer be double-clicked in order to collapse it. However, based on what I gathered from ddahl, the collapsing behavior was never considered to be final. Patches to enable more sensible collapsing behavior are forthcoming, and will be linked to from this bug.
Attachment #460716 -
Attachment is obsolete: true
Attachment #460940 -
Flags: feedback?(rcampbell)
Attachment #460716 -
Flags: review?(robert.bugzilla)
Attachment #460716 -
Flags: feedback?(ddahl)
Assignee | ||
Updated•14 years ago
|
Summary: Fix the look and feel of the grippy on the Web Console → Remove the grippy from the Web Console
Comment 7•14 years ago
|
||
Comment on attachment 460940 [details] [diff] [review]
[checked-in] Proposed patch, version 2.
yeah! a patch with removal only!
Attachment #460940 -
Flags: feedback?(rcampbell) → feedback+
Assignee | ||
Updated•14 years ago
|
Attachment #460940 -
Flags: review?(dtownsend)
Updated•14 years ago
|
Attachment #460940 -
Flags: review?(dtownsend) → review+
Updated•14 years ago
|
Attachment #460940 -
Flags: approval2.0+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 8•14 years ago
|
||
Comment on attachment 460940 [details] [diff] [review]
[checked-in] Proposed patch, version 2.
http://hg.mozilla.org/mozilla-central/rev/3c512fbfd912
Attachment #460940 -
Attachment description: Proposed patch, version 2. → [checked-in] Proposed patch, version 2.
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Whiteboard: [kd4b3]
Updated•14 years ago
|
Keywords: checkin-needed
Updated•14 years ago
|
blocking2.0: ? → betaN+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•