Closed
Bug 583232
Opened 14 years ago
Closed 14 years ago
Add rewrapping to jsapi.h
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta5+ |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
(Whiteboard: [compartments] fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
We might as well check this stuff in.
Attachment #461528 -
Flags: review?(gal)
|
Assignee | |
Updated•14 years ago
|
Blocks: compartments
|
||
Comment 1•14 years ago
|
||
Comment on attachment 461528 [details] [diff] [review]
v1
Not sure we need this and not sure I like the obj* version of it, but also not opposed strongly enough to stop you.
Attachment #461528 -
Flags: review?(gal) → review+
|
||
Comment 2•14 years ago
|
||
What happens if there are other refs smeared around the compartment's stack and heap that need to refer to the wrapper now? The objp in/out param won't handle that. Not sure it matters, though.
For something like an MT wrapper it does, so that's why the wrapper becomes the object (swaps guts, assuming its identity).
/be
|
||
Updated•14 years ago
|
blocking2.0: --- → beta5+
|
|
||
Updated•14 years ago
|
Whiteboard: [compartments]
|
|
||
Updated•14 years ago
|
Assignee: general → jorendorff
|
|
||
Updated•14 years ago
|
Assignee: jorendorff → sayrer
|
|
||
Comment 3•14 years ago
|
||
Assignee: sayrer → jorendorff
Whiteboard: [compartments] → [compartments] fixed-in-tracemonkey
|
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/9eaff50687a3 is a followup to fix the Rewrap{Object,Value} -> Wrap{Object,Value} confusion that was landed here.
You need to log in
before you can comment on or make changes to this bug.
Description
•