Closed
Bug 583333
Opened 14 years ago
Closed 14 years ago
error "timeout is not defined" in controller.js
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: harth, Assigned: whimboo)
References
Details
(Keywords: regression, Whiteboard: mozmill-1.4.2+)
Attachments
(1 file)
|
(deleted),
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
Get timeout is not defined", "lineNumber": 428, "stack": "([object Object],true)@resource://mozmill/modules/controller.js:428
when I run:
mozmill -b ~/Shiretoko.app/ --show-errors -t ~/mozmill-tests/firefox/testTabbedBrowsing/testOpenInForeground.js
The line in question does have a 'timeout' that appears to not be initialized anywhere. Regressed with this commit:
http://github.com/mozautomation/mozmill/commit/45213c70e89c05d8a728aa9ca293ffe1fad7b660
|
Reporter | |
Updated•14 years ago
|
Summary: error "Get timeout is not defined" in controller.js → error "timeout is not defined" in controller.js
|
|
Reporter | |
Updated•14 years ago
|
Whiteboard: mozmill-1.4.2?
|
Assignee | |
Comment 1•14 years ago
|
||
Dammit, that's true and there are also other instances:
- this.waitForEval("subject.checked == " + state, 500, 100, element);
+ this.waitFor(function() {
+ return element.checked == state;
+ }, timeout, interval);
We should simply revert it to 500, 100. Meanwhile I feel really bad about all those regressions my new feature has been introduced and no-one has seen during the review cycle. :/
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Blocks: 579943
Keywords: regression
|
|
Assignee | |
Comment 2•14 years ago
|
||
These are all instances I can find.
Attachment #461658 -
Flags: review?(harthur)
|
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 461658 [details] [diff] [review]
Patch v1
cool, thanks Henrik.
Attachment #461658 -
Flags: review?(harthur) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Upps, landed without approval. I hope it's ok, for that regression:
http://github.com/mozautomation/mozmill/commit/0132f28ccb10d1a1b34574f86006bdfcb0895668
http://github.com/mozautomation/mozmill/commit/c1721badf61b46e7772f3a09968ed0a0045ea5e8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•14 years ago
|
Whiteboard: mozmill-1.4.2? → mozmill-1.4.2+
Verified by running testTabbedBrowsing/testOpenInForeground.js
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•