Closed Bug 583675 Opened 14 years ago Closed 14 years ago

JM: "Assertion failure: begin <= end,"

Categories

(Core :: JavaScript Engine, defect)

x86
All
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: gkw, Assigned: adrake)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(1 file, 2 obsolete files)

{
    gczeal(2)
}
(function () {
    ''.w()
})()

asserts js debug shell on JM changeset 2ee92d697741 with -m at Assertion failure: begin <= end, at ../jsgc.cpp:1265
Only occurs on 32bit with ICs enabled.
Hardware: All → x86
Not terribly useful, but bisection results:

Changeset 49100:c387ce88e5b0: bad
The first bad revision is:
changeset:   49100:c387ce88e5b0
parent:      49095:aad930cb9dc0
user:        David Anderson <danderson@mozilla.com>
date:        Thu Jul 29 17:13:08 2010 -0700
summary:     [JAEGER] Conservatively scan the JS stack (bug 583084, GC changes r=gregor).
Assignee: general → adrake
Status: NEW → ASSIGNED
Attached patch Patch v0 (obsolete) (deleted) — Splinter Review
It's a bit of a band-aid, but it would require some pretty major restructuring to make this less ugly, and I don't trust myself to refactor the surrounding code without breaking it. I suspect there are other bugs of this class showing up in other gc failures (tasty tasty gczeal).
Attachment #462322 - Flags: review?(dvander)
Could you explain what is happening here? I don't understand the fix.
Attached patch Patch v1 (obsolete) (deleted) — Splinter Review
Fixes a doc typo that would have left future readers dazed and confused.
Attachment #462322 - Attachment is obsolete: true
Attachment #462325 - Flags: review?(dvander)
Attachment #462322 - Flags: review?(dvander)
Attached patch Patch v2 (deleted) — Splinter Review
Attachment #462325 - Attachment is obsolete: true
Attachment #462329 - Flags: review?(dvander)
Attachment #462325 - Flags: review?(dvander)
Comment on attachment 462329 [details] [diff] [review]
Patch v2

Nice debugging, thanks for taking this. Bad GC interactions sure do suck.
Attachment #462329 - Flags: review?(dvander) → review+
http://hg.mozilla.org/users/danderson_mozilla.com/moo/rev/7465ce759e81
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: