Closed Bug 583941 Opened 14 years ago Closed 14 years ago

testDisabledElements.js uses newly deprecated function

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ahal, Assigned: aaronmt)

References

Details

(Whiteboard: [fixed by bug 584575])

Attachments

(2 files, 1 obsolete file)

A change which rolls 'assertPropertyNotExist()' into 'assertNotProperty()' was just checked into Mozmill 1.4.2. testPrivateBrowsing/testDisabledElements.js was the only test that used this function. To fix: s/assertPropertyNotExist/assertNotProperty/ Note that the old function wasn't removed for 1.4.2, so tests that use it will still work, but will see a deprecation warning in the logs.
Depends on: 583773
Aaron, could you update the test accordingly?
Attached patch Patch v1 - assertNotProperty (obsolete) (deleted) — Splinter Review
s/assertPropertyNotExist/assertNotProperty/
Attachment #462378 - Flags: review?(hskupin)
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Comment on attachment 462378 [details] [diff] [review] Patch v1 - assertNotProperty Remind me to check this in once Mozmill 1.4.2 has been released.
Attachment #462378 - Flags: review?(hskupin) → review+
Whiteboard: [needs landing]
As per the discussion in our weekly meeting this should be changed to either assertNotDOMProperty or assertNotJSProperty instead.
Aaron, can you please do that change and also create a new bug for moving all of our assertJS function calls which check attributes on nodes to assertNotJSProperty/assertJSProperty? Thanks.
Attachment #462378 - Attachment is obsolete: true
Attached patch Patch - assertNotDOMProperty (deleted) — Splinter Review
s/assertNotProperty/assertNotDOMProperty I've never seen this function before so I'm assuming it's the same parameters and usage.
Attachment #463336 - Flags: review?(hskupin)
(In reply to comment #5) > Aaron, can you please do that change and also create a new bug for moving all > of our assertJS function calls which check attributes on nodes to > assertNotJSProperty/assertJSProperty? Thanks. Can you please explain what assertNotJSProperty is, and an example of where you are looking to use it.
Comment on attachment 463336 [details] [diff] [review] Patch - assertNotDOMProperty >- controller.assertPropertyNotExist(importHTML, "disabled"); >+ controller.assertNotDOMProperty(importHTML, "disabled"); assertProperty has been replaced by assertJSProperty which directly checks for the property of the given JS object. AssertDOMProperty will check the DOM attribute instead. That said the above code should use assertNotJSProperty.
Attachment #463336 - Flags: review?(hskupin) → review-
Whiteboard: [needs landing]
Hopefully I got this right. Apologize, was confused with the name changes and adjusting to the different names, it wasn't clear at first.
Attachment #464865 - Flags: review?(hskupin)
Attachment #464865 - Flags: review?(hskupin) → review+
Whiteboard: [needs landing][not before Mozmill 1.4.2]
No longer blocks: 585086
Fixed by bug 584575.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Depends on: 584575
Resolution: --- → FIXED
Whiteboard: [needs landing][not before Mozmill 1.4.2] → [fixed by bug 584575]
Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Version: Trunk → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: