Closed
Bug 583941
Opened 14 years ago
Closed 14 years ago
testDisabledElements.js uses newly deprecated function
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: aaronmt)
References
Details
(Whiteboard: [fixed by bug 584575])
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
whimboo
:
review-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
A change which rolls 'assertPropertyNotExist()' into 'assertNotProperty()' was just checked into Mozmill 1.4.2.
testPrivateBrowsing/testDisabledElements.js was the only test that used this function.
To fix: s/assertPropertyNotExist/assertNotProperty/
Note that the old function wasn't removed for 1.4.2, so tests that use it will still work, but will see a deprecation warning in the logs.
Reporter | ||
Updated•14 years ago
|
Comment 1•14 years ago
|
||
Aaron, could you update the test accordingly?
Assignee | ||
Comment 2•14 years ago
|
||
s/assertPropertyNotExist/assertNotProperty/
Attachment #462378 -
Flags: review?(hskupin)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Comment 3•14 years ago
|
||
Comment on attachment 462378 [details] [diff] [review]
Patch v1 - assertNotProperty
Remind me to check this in once Mozmill 1.4.2 has been released.
Attachment #462378 -
Flags: review?(hskupin) → review+
Updated•14 years ago
|
Whiteboard: [needs landing]
Reporter | ||
Comment 4•14 years ago
|
||
As per the discussion in our weekly meeting this should be changed to either assertNotDOMProperty or assertNotJSProperty instead.
Comment 5•14 years ago
|
||
Aaron, can you please do that change and also create a new bug for moving all of our assertJS function calls which check attributes on nodes to assertNotJSProperty/assertJSProperty? Thanks.
Updated•14 years ago
|
Attachment #462378 -
Attachment is obsolete: true
Assignee | ||
Comment 6•14 years ago
|
||
s/assertNotProperty/assertNotDOMProperty
I've never seen this function before so I'm assuming it's the same parameters and usage.
Attachment #463336 -
Flags: review?(hskupin)
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #5)
> Aaron, can you please do that change and also create a new bug for moving all
> of our assertJS function calls which check attributes on nodes to
> assertNotJSProperty/assertJSProperty? Thanks.
Can you please explain what assertNotJSProperty is, and an example of where you are looking to use it.
Comment 8•14 years ago
|
||
Comment on attachment 463336 [details] [diff] [review]
Patch - assertNotDOMProperty
>- controller.assertPropertyNotExist(importHTML, "disabled");
>+ controller.assertNotDOMProperty(importHTML, "disabled");
assertProperty has been replaced by assertJSProperty which directly checks for the property of the given JS object. AssertDOMProperty will check the DOM attribute instead. That said the above code should use assertNotJSProperty.
Attachment #463336 -
Flags: review?(hskupin) → review-
Updated•14 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 9•14 years ago
|
||
Hopefully I got this right. Apologize, was confused with the name changes and adjusting to the different names, it wasn't clear at first.
Attachment #464865 -
Flags: review?(hskupin)
Updated•14 years ago
|
Attachment #464865 -
Flags: review?(hskupin) → review+
Updated•14 years ago
|
Whiteboard: [needs landing][not before Mozmill 1.4.2]
Comment 10•14 years ago
|
||
Fixed by bug 584575.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Depends on: 584575
Resolution: --- → FIXED
Whiteboard: [needs landing][not before Mozmill 1.4.2] → [fixed by bug 584575]
Comment 11•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Version: Trunk → unspecified
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•