Closed Bug 583942 Opened 14 years ago Closed 11 years ago

JM: need trace-tests for getelem PICs in tests/pic

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

We don't seem to have trace-tests for getelem PICs. This is not good.
Assignee: general → cdleary
Status: NEW → ASSIGNED
No PIC-like thingies in TM or old interp for GETELEM -- maybe we should rename trace-test to test2 ;-).

/be
There are some getelem sanity tests under trace-test/jaeger, but I'll look at the bugs and move the existing sanity checks.
dmandelin, any particular categories of the test space you want to make sure we cover? I remember you making suggestions outside what we found in mochitest/fuzzer bugs.
I think I was thinking about the various combinations of different stub types generated and PIC resets.
dmandelin mentioned that he wanted to take this in bug 602641 comment 8 -- since it's white-boxy testing, it makes sense to tailor this to the new implementation, which nobody has had me look at.
Assignee: cdleary → dmandelin
Are more tests still needed for this bug?
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.