Closed
Bug 584193
Opened 14 years ago
Closed 14 years ago
fix print preview for 130078
Categories
(Core :: Print Preview, defect)
Core
Print Preview
Tracking
()
RESOLVED
FIXED
People
(Reporter: tnikkel, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•14 years ago
|
||
This is roc's patch that I have scavenged.
Attachment #462521 -
Flags: review?(Olli.Pettay)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 462521 [details] [diff] [review]
patch
I'm atm on OSX so couldn't test printpreview. But the changes look
reasonable.
Attachment #462521 -
Flags: review?(Olli.Pettay) → review+
|
|
Reporter | |
Comment 3•14 years ago
|
||
I've done basic tests of print and print preview on Linux and Windows with this patch + 130078.
|
|
Reporter | |
Comment 4•14 years ago
|
||
Landed
http://hg.mozilla.org/mozilla-central/rev/86e8ec17e532
but backed out due to bug 585496. I guess I forgot to test this without 130078.
http://hg.mozilla.org/mozilla-central/rev/682eee29d90d
http://hg.mozilla.org/mozilla-central/rev/1831e8e87545
|
|
Reporter | |
Comment 5•14 years ago
|
||
Is it worth spending any time trying to figure out why this doesn't work without 130078, or should we just land this at the same time as 130078?
The latter I guess
I'm using an hourly build with 130078 relanded, and I can print preview pages just fine.
Is this still a bug for other people?
|
|
Reporter | |
Comment 8•14 years ago
|
||
This bug landed at the same time as bug 130078. I haven't got around to marking all the bugs that landed with 130078 fixed yet.
|
|
Reporter | |
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•