Closed
Bug 584551
Opened 14 years ago
Closed 14 years ago
XPCCallContext enters requests in the wrong order
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta3+ |
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Whiteboard: [4b3] fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
Currently, XPCCallContext::Init enters the request on the new context before pushing it onto the context stack. Pushing a context onto the context stack causes us to set aside the stack chain on it, forcing us to enter a request on it. If the old context was previously in a request, however, this breaks the stack-based discipline that bug 552266 forces on us. In order to avoid this, we need to reverse the order of operations.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Updated•14 years ago
|
Attachment #462987 -
Flags: review?(igor) → review+
|
||
Updated•14 years ago
|
blocking2.0: --- → beta3+
|
||
Updated•14 years ago
|
Whiteboard: [4b3]
|
|
||
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [4b3] → [4b3] fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
Verified that this doesn't crash when I drag tabs to the desktop - for some reason I lost the ability to drop tabs on the desktop for a moment, but it seems to be working now.
You need to log in
before you can comment on or make changes to this bug.
Description
•