Closed Bug 584669 Opened 14 years ago Closed 7 years ago

Remove old bookmarks button in favour of the new one

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
minor

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: imradyurrad, Unassigned)

References

Details

User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b4pre) Gecko/20100804 Minefield/4.0b4pre Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b4pre) Gecko/20100804 Minefield/4.0b4pre Quoting myself "Now that we have an improved bookmarks button, shouldn't the old one be removed? It's basically become useless. The only advantage it has compared to the new one is that it only takes one click. This could be given to the new one by middle clicking it. And it's kind of confusing having two "bookmarks" in the toolbar customization window." Reproducible: Always
Component: General → Bookmarks & History
We should probably relabel the one item to Bookmarks Sidebar and the other to Bookmarks Menu, at least when they are in the customization UI.
just a note: the button is taking label from the broadcaster that is also giving name to the sidebar menuitem. So it's not just matter of changing the string, we'll need a new entry. No reason to stay unconfirmed btw.
Blocks: 544817
Status: UNCONFIRMED → NEW
Ever confirmed: true
Taz, well, not useless, as even the new Bookmarks Menu Widget will open the Bookmarks Sidebar Widget and both have different icons, one with a drop menu button the other not. I use both icons myself. Related: Might be nice if History also matched while where at it as it opens as a sidebar too. I know one of the addons makes a History Menu Widget and also calls that History.
I don't see the argument here. The new button functionally serves the purpose of the old one and more. The only advantage it has would be the one click thing I mentioned in comment 0.
The bookmarks menu button could be made a splitbutton, which would provide both features, but I don't know whether the UX people would want a behaviour change like that.
(In reply to comment #5) > The bookmarks menu button could be made a splitbutton, which would provide both > features, but I don't know whether the UX people would want a behaviour change > like that. I thought about that, but then the dropdown would be a really small click target for all the functionality it has. While open in sidebar function (The button) would have much more clicking space for a little benefit.
(In reply to comment #4) > I don't see the argument here. The new button functionally serves the purpose > of the old one and more. The only advantage it has would be the one click thing > I mentioned in comment 0. It's a significant advantage. The side bar is too cumbersome for me, but I do use the traditional bookmarks button to toggle the bookmarks toolbar (<http://en.design-noir.de/mozilla/bookmarks-button/>). I haven't used the new button yet, I guess because of the numerous menu items preceding the actual bookmark items. All this counts in order to access a bookmark efficiently.
(In reply to comment #7) That's why I proposed that middle clicking the new button should open the sidebar. The new one has all the same functions as the first so there's not much reason to have both.
(In reply to comment #8) > That's why I proposed that middle clicking the new button should open the > sidebar. Which I don't actually want, as I said, but lets not focus too much on my special needs... Your suggestion also just sounds pretty weird and non-discoverable.
(In reply to comment #7) > (In reply to comment #4) > It's a significant advantage. I agree .. I like having the 1 click widget which has a sole purpose and is easy to understand, as simple is usually better, even if its still separate from more prominent features with its own widget which I like one click there too. The splitbutton to me doesn't make UX sense, only functional sense. Anything besides keep it simple usually just confuses people and degrades UX many times.
(In reply to comment #6) > I thought about that, but then the dropdown would be a really small click > target for all the functionality it has. While open in sidebar function (The > button) would have much more clicking space for a little benefit. Instead of the button opening the sidebar, have it show only the bookmark menu and unsorted bookmark submenu. Have the dropdown include all the other commands: Bookmark All Tabs, Organize Bookmarks, View Bookmark Toolbar, Show in Sidebar.
(In reply to comment #11) That defeats the whole purpose behind the new button. Why split it up into two buttons?
QA Contact: general → bookmarks
blocking2.0: --- → ?
blocking2.0: ? → ---
How exactly is a menu that disappears as you use it in any way the same as a Sidebar where you can organize and launch multiple sites quickly? The Bookmarks menu was never considered redundant to the Sidebar, and all this button is is the Bookmarks menu with an icon added.
(In reply to comment #14) Already explained why. Read my past comments.
Two unrelated ideas have been brought up: it's unclear what the difference between the two buttons is until you try them. It would be nice if they were better distinguished during customization (perhaps one could be labeled "Bookmarks Menu" just during customization). Or, at least the alt-text could say "Display the bookmarks menu" instead of "Display your bookmarks" for both. Second, even if both bookmarks buttons were kept, some kind of middle-click behavior could still be implemented. Before, I tried middle clicking the bookmarks menu button and was disappointed when the bookmarks organizer did not appear. So it's at least marginally discoverable.
AFAICT, there is a pending redesign of the star and these buttons, so this may be quite low prio compared to that.
We no longer have the old bookmarks button, hence works for me.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.