Closed
Bug 584752
Opened 14 years ago
Closed 14 years ago
Make Modern work nicely with places bookmarks work
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(blocking-seamonkey2.1 a3+)
RESOLVED
FIXED
seamonkey2.1a3
| Tracking | Status | |
|---|---|---|
| blocking-seamonkey2.1 | --- | a3+ |
People
(Reporter: kairo, Assigned: kairo)
References
Details
(Keywords: modern)
Attachments
(1 file)
|
(deleted),
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Bug 580660 at least, maybe other places bookmarks work, introduces some Classic theme changes that should be ported in a reasonable way to Modern.
|
Assignee | |
Comment 1•14 years ago
|
||
Here's a patch that should get everything my places bookmarks patches do to modern. The Classic parts matching this are done in bug 580660 and bug 580662. I copied the icons from there and modified them to match the Modern color scheme as well as I could.
|
|
Assignee | |
Updated•14 years ago
|
blocking-seamonkey2.1: --- → ?
We should be trying to at least match classic for a3, so blocking for the moment.
blocking-seamonkey2.1: ? → a3+
Version: unspecified → Trunk
Comment on attachment 463952 [details] [diff] [review]
v1: Modern changes for places bookmarks
Could you make sure either the existing follow-up bugs for classic also cover modern or you have parallel follow-up bugs for modern. Thanks.
Attachment #463952 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Could you make sure either the existing follow-up bugs for classic also cover
> modern or you have parallel follow-up bugs for modern. Thanks.
Sure, my plans are to address both Classic and Modern in sync in bug 585601.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Pushed the patch as http://hg.mozilla.org/comm-central/rev/f8a85fd368e3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 6•14 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > Could you make sure either the existing follow-up bugs for classic also cover
> > modern or you have parallel follow-up bugs for modern. Thanks.
> Sure, my plans are to address both Classic and Modern in sync in bug 585601.
Any nits will almost certainly apply equally to both themes.
You need to log in
before you can comment on or make changes to this bug.
Description
•