Closed
Bug 584863
Opened 14 years ago
Closed 14 years ago
Have nsHttpChannel::AsyncOpen fail immediately if the channel has already been cancelled.
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | 2.0a1+ | --- |
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
So right now in nsHttpChannel (ie non-e10s) if you cancel a channel before AsyncOpen, nsHttpChannel still goes through all the motions of notifying listeners, adding to loadgroup etc, and then calls OnStart/Stop with the cancel status.
bz and I agree that this isn't needed, and it'll make e10s cancel (bug 536317) simpler to just have AsyncOpen return mStatus immediately if the channel has been canceled already.
Attachment #463289 -
Flags: review?(bzbarsky)
|
Assignee | |
Comment 1•14 years ago
|
||
Requesting blocking-fennec-2.0a1 since this blocks cancel.
tracking-fennec: --- → ?
|
||
Updated•14 years ago
|
Attachment #463289 -
Flags: review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #463289 -
Flags: review?(bzbarsky)
|
||
Updated•14 years ago
|
tracking-fennec: ? → 2.0a1+
|
|
||
Updated•14 years ago
|
Assignee: nobody → jduell.mcbugs
|
||
Comment 2•14 years ago
|
||
Can this land? No rush I suppose, since we can land it along with Cancel.
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/projects/electrolysis/rev/1c49a68f1f6b
Landed on e10s, will be merged tonight.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•