Closed Bug 584998 Opened 14 years ago Closed 2 years ago

mark deprecated xpcom interfaces and methods with [deprecated]

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: timeless, Unassigned)

References

Details

Attachments

(1 file)

We have a way to mark interfaces and methods as deprecated which some compilers are able to use to complain about deprecation. This bug is for sprinkling that marker into caps xpcom files. Please note that at this time we only properly trigger these compile time warnings with msvc (bug 584953 covers the fixing the gcc side).
Attached patch patch (deleted) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #463485 - Flags: review?(benjamin)
Comment on attachment 463485 [details] [diff] [review] patch I don't think this works the way you want, unfortunately. I tried to add [deprecated] to a few XPCOM component methods, and MSVC warns at the time you *implement* the API, not just when you use it, which leads to undesirable warning-spam.
Attachment #463485 - Flags: review?(benjamin) → review-
Depends on: 578478
No longer depends on: 584960
(In reply to comment #2) > I don't think this works the way you want, unfortunately. I tried to add > [deprecated] to a few XPCOM component methods, and MSVC warns at the time you > *implement* the API, not just when you use it, which leads to undesirable > warning-spam. Actually, it warns at the time you declare the method (which may be when you implement it). You can disable the warning for small areas where you know you are hitting it but it's OK: http://msdn.microsoft.com/en-us/library/ttcz0bys%28VS.80%29.aspx And you can turn it back on by doing the same thing, but s/disable/default/

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: timeless → nobody
Status: ASSIGNED → NEW

nsITraceRefcnt and nsISupportsArray no longer exist.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: