Closed
Bug 585264
Opened 14 years ago
Closed 14 years ago
Tabbrowser should tell Gecko which tab is active and which isn't.
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Port the tabbrowser parts of Bug 343515 (need API for tabbrowsers to tell docshells they're visible/hidden)
|
Assignee | |
Comment 1•14 years ago
|
||
Overheard in #seamonkey:
<KaiRo> wonders if someone could port the tabbrowser part of http://hg.mozilla.org/mozilla-central/rev/b7836c3a63db to our side.
This patch ports the Firefox tabbrowser changes and passes the tests in attachment 461367 [details] [diff] [review].
Attachment #463768 -
Flags: superreview?(neil)
Attachment #463768 -
Flags: review?(neil)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 463768 [details] [diff] [review]
Patch v1.0 straight port
>+ // We start our browsers out as inactive, and then maintain
>+ // activeness in the tab switcher.
>+ b.docShell.isActive = false;
> }
>
> if (aFocusNewTab) {
> var parentTab = this.selectedTab;
> this.selectedTab = t;
> this.mPreviousTab = parentTab;
> }
> else
Is it worth moving that line down here?
|
|
||
Comment 3•14 years ago
|
||
(In reply to comment #1)
> This patch ports the Firefox tabbrowser changes and passes the tests in
> attachment 461367 [details] [diff] [review].
OK, just to make this clear, these are tests that landed and we run and fail now, right?
|
|
Assignee | |
Comment 4•14 years ago
|
||
> Is it worth moving that line down here?
Moved. All tests still pass.
Obviously it would be good to land this patch before the tests land.
Attachment #463768 -
Attachment is obsolete: true
Attachment #464046 -
Flags: superreview?(neil)
Attachment #464046 -
Flags: review?(neil)
Attachment #463768 -
Flags: superreview?(neil)
Attachment #463768 -
Flags: review?(neil)
|
|
||
Updated•14 years ago
|
Attachment #464046 -
Flags: superreview?(neil)
Attachment #464046 -
Flags: superreview+
Attachment #464046 -
Flags: review?(neil)
Attachment #464046 -
Flags: review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/97bab6aae962
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•