Closed
Bug 585285
Opened 14 years ago
Closed 14 years ago
Make styling for type="menu-button" toolbarbuttons respect the toolbarbutton-1 class
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 4.0b5
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
asaf
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Our custom styling for primary toolbarbuttons depends on the toolbarbutton-1 class, except for type="menu-button", where we always impose the styling. This leads to inconsistent add-on toolbars such as the one in attachment 461527 [details].
Attachment #463777 -
Flags: review?(mano)
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dao
Version: unspecified → Trunk
|
|
Assignee | |
Comment 1•14 years ago
|
||
updated to tip
Attachment #463777 -
Attachment is obsolete: true
Attachment #466086 -
Flags: review?(mano)
Attachment #466086 -
Flags: review?(gavin.sharp)
Attachment #463777 -
Flags: review?(mano)
|
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → ?
|
|
Assignee | |
Comment 2•14 years ago
|
||
updated to tip
Attachment #466086 -
Attachment is obsolete: true
Attachment #466977 -
Flags: review?(mano)
Attachment #466977 -
Flags: review?(gavin.sharp)
Attachment #466086 -
Flags: review?(mano)
Attachment #466086 -
Flags: review?(gavin.sharp)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 466977 [details] [diff] [review]
patch
r=mano
Attachment #466977 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #466977 -
Flags: review?(gavin.sharp) → approval2.0?
|
||
Updated•14 years ago
|
Attachment #466977 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre
Thank you!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•