Closed Bug 585628 Opened 14 years ago Closed 14 years ago

Shared builds broken building xpcshell by bug 579178 - manifest enumeration changes

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b4

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Possible fix
(deleted), patch
benjamin
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review
Attached patch Possible fix (deleted) — — Splinter Review
Bug 579178 broke shared builds: link -NOLOGO -OUT:xpcshell.exe -PDB:xpcshell.pdb -NXCOMPAT -DYNAMICBASE -SAFESEH -DEBUG -DEBUGTYPE:CV xpcshell.obj ./module.res ../../../../dist/lib/xpcomglue_s.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/xpcom.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/xul.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/mozalloc.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/mozjs.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/nspr4.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/plc4.lib e:/buildbot/comm-central-trunk-bloat-win32/build/objdir-tb/mozilla/dist/lib/plds4.lib kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib xpcshell.obj : error LNK2019: unresolved external symbol __imp__XRE_AddManifestLocation referenced in function _main NEXT ERROR xpcshell.exe : fatal error LNK1120: 1 unresolved externals Possible fix attached, I'm currently building this, though I am told it has compiled on windows.
This patch lets me build Thunderbird and run xpcshell tests on OS X 10.6, fwiw.
Comment on attachment 464067 [details] [diff] [review] Possible fix This should fix the bustage for shared builds.
Attachment #464067 - Flags: review?(benjamin)
Attachment #464067 - Flags: approval2.0?
Attachment #464067 - Flags: review?(benjamin)
Attachment #464067 - Flags: review+
Attachment #464067 - Flags: approval2.0?
Attachment #464067 - Flags: approval2.0+
Checked in: http://hg.mozilla.org/mozilla-central/rev/66819a83b0f6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: