Closed
Bug 585727
Opened 14 years ago
Closed 14 years ago
Make Mozmill-test testEscapeAutocomplete local
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u279076, Assigned: aaronmt)
References
Details
(Whiteboard: [litmus-data])
Attachments
(2 files)
|
(deleted),
patch
|
u279076
:
review-
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
u279076
:
review+
whimboo
:
review+
|
Details | Diff | Splinter Review |
Module: testAwesomeBar/testEscapeAutocomplete.js
Test-page: Use any 2 pages from test-files/layout/mozilla*
|
Assignee | |
Comment 1•14 years ago
|
||
cleanup + converts test to make use of local-data
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #469893 -
Flags: review?(anthony.s.hughes)
Comment on attachment 469893 [details] [diff] [review]
Patch v1 - (default)
>+var setupModule = function()
> {
>
> var testEscape = function()
> {
Please move {
Attachment #469893 -
Flags: review?(anthony.s.hughes) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #474225 -
Flags: review?(anthony.s.hughes)
Attachment #474225 -
Flags: review?(hskupin)
Attachment #474225 -
Flags: review?(anthony.s.hughes)
Attachment #474225 -
Flags: review+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 474225 [details] [diff] [review]
Patch v1.1 [nit fix] - (default)
I don't like the last assertJS calls because of the string operations but we can fix that when moving to assert. r=me
Attachment #474225 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
(In reply to comment #3)
> Created attachment 474225 [details] [diff] [review]
> Patch v1.1 [nit fix] - (default)
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/1f7019ac9ea0 [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/686888dac354 [mozilla1.9.2]
http://hg.mozilla.org/qa/mozmill-tests/rev/7c37b4515ff1 [mozilla1.9.1]
|
|
||
Comment 6•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•