Closed
Bug 585729
Opened 14 years ago
Closed 14 years ago
Make Mozmill-test testGoButton local
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u279076, Assigned: aaronmt)
References
Details
(Whiteboard: [litmus-data])
Attachments
(5 files, 1 obsolete file)
|
(deleted),
patch
|
u279076
:
review-
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
u279076
:
review+
whimboo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Module: testAwesomeBar/testGoButton.js
Test-page: Use any 2 pages from test-files/layout/mozilla*
|
Assignee | |
Comment 1•14 years ago
|
||
cleanup + converts test to local-data
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #466413 -
Flags: review?(anthony.s.hughes)
Comment on attachment 466413 [details] [diff] [review]
Patch v1 - (default)
>+const LOCAL_TEST_FOLDER = collector.addHttpResource('../test-files/');
>+const LOCAL_TEST_PAGES = [
>+ {url: LOCAL_TEST_FOLDER + 'layout/mozilla.html'},
>+ {url: LOCAL_TEST_FOLDER + 'layout/mozilla_mission.html'}
>+];
No need to use url member here. Only use members when there is more than one member per element.
Attachment #466413 -
Flags: review?(anthony.s.hughes) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
fix as commented in comment #2
Attachment #469151 -
Flags: review?(anthony.s.hughes)
Attachment #469151 -
Flags: review?(hskupin)
Attachment #469151 -
Flags: review?(anthony.s.hughes)
Attachment #469151 -
Flags: review+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 469151 [details] [diff] [review]
Patch v2 - (default)
>+ // Check if an element with an id of 'organization' exists and the Go button is hidden
>+ controller.assertNode(new elementslib.ID(controller.tabs.activeTab, "organization"));
Please separate element creation and the check into two different lines.
Also please check that the test passes with the now combined location bar button.
r=me with the above change.
Attachment #469151 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Fix from comment above. Test passes with respect to changes in the repositioning of the go/stop/reload buttons on the location bar.
(In reply to comment #5)
> Created attachment 473334 [details] [diff] [review]
> Patch v2.1 - [fix] - (default)
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/df9d65a4e10c
Please followup with 1.9.1 and 1.9.2 patches as necessary.
|
|
Assignee | |
Comment 7•14 years ago
|
||
Attachment #473658 -
Flags: review?(anthony.s.hughes)
Attachment #473658 -
Flags: review?(anthony.s.hughes) → review+
(In reply to comment #7)
> Created attachment 473658 [details] [diff] [review]
> Patch v2.1 - (1.9.2)
Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/97ba80491c8e
|
|
Assignee | |
Comment 9•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474202 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•14 years ago
|
||
Missed one nit line missing from now obsolete patch
Keywords: checkin-needed
|
Reporter | |
Comment 11•14 years ago
|
||
(In reply to comment #10)
> Created attachment 474203 [details] [diff] [review]
> Patch v2.1 - (1.9.1)
>
> Missed one nit line missing from now obsolete patch
Landed on mozilla1.9.1:
http://hg.mozilla.org/qa/mozmill-tests/rev/9a620251195a
|
|
||
Comment 12•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•