Module: testAwesomeBar/testSuggestHistoryBookmarks.js Test-page: Use any 1 page from test-files/layout/mozilla*

Unsure if I should proceed with the changes here or if it's best to wait for a clean test with a fix from bug 592411

(In reply to comment #1) > Unsure if I should proceed with the changes here or if it's best to wait for a > clean test with a fix from bug 592411 The two are unrelated. You should be able to make this test local without affecting any changes in testPlacesAPI.js.

cleanup + converts test to make use of local content and data

Comment on attachment 471182 [details] [diff] [review] Patch v1 - (default) >+ for each (var entry in entries) { > controller.assertJS("subject.enteredTitle == subject.underlinedTitle", >+ {enteredTitle: LOCAL_TEST_PAGE.string, underlinedTitle: entry.toLowerCase()}); Can you put each member on its own line? >+ for each (var entry in entries) { > controller.assertJS("subject.enteredTitle == subject.underlinedTitle", >+ {enteredTitle: LOCAL_TEST_PAGE.string, underlinedTitle: entry.toLowerCase()}); > } Same here please.

Comment on attachment 473530 [details] [diff] [review] Patch v1.1 - [nit fixes] - (default) >-var setupModule = function(module) >+var setupModule = function() nit: bracket fixes please. Otherwise r=me.

(In reply to comment #6) > Created attachment 473530 [details] [diff] [review] > Patch v1.1 - [nit fixes] - (default) This patch causes a regression failure... Fail: controller.assertJS: Failed for 'subject.getNumberOfVisibleRows() == 1' File: firefox/testAwesomeBar/testSuggestHistoryBookmarks.js:96 Please fix this failure and resubmit your patch.

(In reply to comment #8) > (In reply to comment #6) > > Created attachment 473530 [details] [diff] [review] [details] > > Patch v1.1 - [nit fixes] - (default) > > This patch causes a regression failure... > > Fail: controller.assertJS: Failed for 'subject.getNumberOfVisibleRows() == 1' > File: firefox/testAwesomeBar/testSuggestHistoryBookmarks.js:96 > > Please fix this failure and resubmit your patch. Ah, we we're using a unique site in the online version - 'litmus'. When typed into the awesomebar, it was unique enough to pull in one visible row. When we switched to generic local mozilla pages, we were using 'mozilla', which pulled in the default bookmarks as well. I changed this to mozilla-grants and we type 'grants' if that's alright. We pull in one visible row like before. Second failure is due to bug 592411

Comment on attachment 478033 [details] [diff] [review] Patch v1.2 - (default) Regression seems to have been fixed. r+

(In reply to comment #10) > Comment on attachment 478033 [details] [diff] [review] > Patch v1.2 - (default) Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/814880ff6a9a [default] http://hg.mozilla.org/qa/mozmill-tests/rev/4545022fc526 [mozilla1.9.2] http://hg.mozilla.org/qa/mozmill-tests/rev/4a2cad352343 [mozilla1.9.1]

Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.