Closed Bug 585757 Opened 14 years ago Closed 14 years ago

Make Mozmill-test testRemoveCookie.js local

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: u279076, Assigned: aaronmt)

References

Details

(Whiteboard: [litmus-data])

Attachments

(5 files, 9 obsolete files)

Patch v1.2 - (default)
(deleted), patch
u279076
: review+
whimboo
: review+
Details | Diff | Splinter Review
Patch v1.2 - (1.9.2)
(deleted), patch
Details | Diff | Splinter Review
Patch v1.3 - (default) + [indent fix]
(deleted), patch
aaronmt
: review+
Details | Diff | Splinter Review
Patch v1.3 - (1.9.2) + [indent fix]
(deleted), patch
aaronmt
: review+
Details | Diff | Splinter Review
Patch v1.3 - (1.9.1) + [indent fix]
(deleted), patch
u279076
: review+
Details | Diff | Splinter Review
Module: testCookies/testRemoveCookie.js Test-page: test-files/cookies/cookie_single.html
Blocks: 579965
Attached patch Patch v1 - (default) (obsolete) (deleted) — — Splinter Review
cleanup + converts test to make use of local-data
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #467008 - Flags: review?(anthony.s.hughes)
Comment on attachment 467008 [details] [diff] [review] Patch v1 - (default) Looks good, r+. Over to Henrik for additional review.
Attachment #467008 - Flags: review?(hskupin)
Attachment #467008 - Flags: review?(anthony.s.hughes)
Attachment #467008 - Flags: review+
Comment on attachment 467008 [details] [diff] [review] Patch v1 - (default) >+var setupModule = function() > { Please fix the bracing for all functions. >+ cm = Cc["@mozilla.org/cookiemanager;1"].getService(Ci.nsICookieManager2); Please always move down calls to methods of objects into the next line. With those changes you can take over r=me.
Attachment #467008 - Flags: review?(hskupin) → review+
Attached patch Patch v1.1 - (default) (obsolete) (deleted) — — Splinter Review
fixes from comment above
Keywords: checkin-needed
Comment on attachment 471502 [details] [diff] [review] Patch v1.1 - (default) >- module.cm = Cc["@mozilla.org/cookiemanager;1"].getService(Ci.nsICookieManager2); >+ cm = Cc["@mozilla.org/cookiemanager;1"] >+ .getService(Ci.nsICookieManager2); It's a nit bug please use: >+ cm = Cc["@mozilla.org/cookiemanager;1"]. >+ getService(Ci.nsICookieManager2);
Attached patch Patch v1.1 [indent fix] - (default) (obsolete) (deleted) — — Splinter Review
Attachment #471502 - Attachment is obsolete: true
(In reply to comment #6) > Created attachment 471567 [details] [diff] [review] > Patch v1.1 [indent fix] - (default) Landed on default: http://hg.mozilla.org/qa/mozmill-tests/rev/152fe346f198 Please follow up with 1.9.2 and 1.9.1 patches as appropriate.
Attached patch Patch v1.1 - (1.9.2) (obsolete) (deleted) — — Splinter Review
Attachment #473675 - Flags: review?(anthony.s.hughes)
Attachment #473675 - Flags: review?(anthony.s.hughes) → review+
(In reply to comment #8) > Created attachment 473675 [details] [diff] [review] > Patch v1.1 - (1.9.2) Landed on mozilla1.9.2: http://hg.mozilla.org/qa/mozmill-tests/rev/1beb92ab829e
Attached patch Patch v1.1 - (1.9.1) (obsolete) (deleted) — — Splinter Review
Please revise the patches for default and mozmill1.9.2 so those do not test cookies for .mozilla.org. We need follow-up patches.
Attachment #474217 - Attachment is obsolete: true
Attached patch Patch v1.2 - (default) [localhost fix] (obsolete) (deleted) — — Splinter Review
s/.mozilla.org/localhost
Attachment #475954 - Flags: review?(anthony.s.hughes)
Attached patch Patch v1.2 - (1.9.2) [localhost fix] (obsolete) (deleted) — — Splinter Review
1.9.2
Attachment #475955 - Flags: review?(anthony.s.hughes)
Attachment #475955 - Flags: review?(anthony.s.hughes)
Attachment #475954 - Flags: review?(anthony.s.hughes)
Attachment #475954 - Attachment is obsolete: true
Attachment #475955 - Attachment is obsolete: true
Attached patch Patch v1.2 - (default) [localhost fix] (obsolete) (deleted) — — Splinter Review
Forgot to change the name: litmus_1
Attachment #475966 - Flags: review?(anthony.s.hughes)
Attached patch Patch v1.2 - (1.9.2) [localhost fix] (obsolete) (deleted) — — Splinter Review
Attachment #475967 - Flags: review?(anthony.s.hughes)
Comment on attachment 475966 [details] [diff] [review] Patch v1.2 - (default) [localhost fix] Path should be /cookies/
Attachment #475966 - Attachment is obsolete: true
Attachment #475966 - Flags: review?(anthony.s.hughes)
Comment on attachment 475967 [details] [diff] [review] Patch v1.2 - (1.9.2) [localhost fix] Path should be /cookies/
Attachment #475967 - Attachment is obsolete: true
Attachment #475967 - Flags: review?(anthony.s.hughes)
Attached patch Patch v1.2 - (default) (deleted) — — Splinter Review
+ added the persistence object as per Henrik's suggestion in the other cookie bugs + proper path of cookie is /cookies/
Attachment #477727 - Flags: review?(anthony.s.hughes)
Attached patch Patch v1.2 - (1.9.2) (deleted) — — Splinter Review
Attachment #467008 - Attachment is obsolete: true
Attachment #471567 - Attachment is obsolete: true
Attachment #473675 - Attachment is obsolete: true
Attachment #477727 - Flags: review?(hskupin)
Attachment #477727 - Flags: review?(anthony.s.hughes)
Attachment #477727 - Flags: review+
(In reply to comment #19) > Created attachment 477728 [details] [diff] [review] > Patch v1.2 - (1.9.2) Diff between two patches is essentially the same (diff on comments). An r+ on the default patch will be assumed for this patch as well.
Comment on attachment 477727 [details] [diff] [review] Patch v1.2 - (default) >+ persisted.hostName = {}; undefined please. >- var removed = !cm.cookieExists({host: ".mozilla.org", name: "__utmz", path: "/"}); >+ var removed = !cm.cookieExists({host: persisted.hostName, >+ name: "litmus_1", >+ path: "/cookies/"}); Please update the indentation: >+ var removed = !cm.cookieExists({ >+ host: persisted.hostName, >+ name: "litmus_1", > controller.assertJS("subject.list.view.rowCount == subject.numberCookies", >- {list: cookiesList, numberCookies: origNumCookies - 1}); >+ {list: cookiesList, >+ numberCookies: origNumCookies - 1}); Same here. With those changes r=me.
Attachment #477727 - Flags: review?(hskupin) → review+
Comment on attachment 477728 [details] [diff] [review] Patch v1.2 - (1.9.2) This patch also needs the requested updates as the default one.
Attachment #478294 - Flags: review+
Attachment #478295 - Flags: review+
Looks like the initial changes never landed on 1.9.1 as the patch wouldn't apply. Requesting review to play it safe
Attachment #478296 - Flags: review?(anthony.s.hughes)
Keywords: checkin-needed
Attachment #478296 - Flags: review?(anthony.s.hughes) → review+
(In reply to comment #23) > Created attachment 478294 [details] [diff] [review] > Patch v1.3 - (default) + [indent fix] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/30e5398131dd [default]
(In reply to comment #24) > Created attachment 478295 [details] [diff] [review] > Patch v1.3 - (1.9.2) + [indent fix] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/e81f9f5e17c4 [mozilla1.9.2]
(In reply to comment #25) > Created attachment 478296 [details] [diff] [review] > Patch v1.3 - (1.9.1) + [indent fix] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/996a6e0599f0 [mozilla1.9.1]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: