Closed
Bug 585776
Opened 14 years ago
Closed 14 years ago
display of close buttons on unselected tabs no longer consistent (browser.tabs.tabClipWidth broken)
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 4.0b5
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: fryn, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
video/quicktime
|
Details | |
|
(deleted),
patch
|
asaf
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. Open tabs until the close buttons on unselected tabs switch from displayed to hidden.
2. Close 1 tab. Close buttons on unselected tabs are still hidden.
3. Close 1 tab. Close buttons on unselected tabs are displayed.
Extra steps to confirm:
4. (Re)open 1 tab. Close buttons remain displayed.
5. (Re)open 1 tab. Close buttons are hidden.
Expected results:
After step 2, close buttons should have been displayed.
This regression seems to have occurred after the landing of the patch for bug 380960 - Implement closing tabs animation. Do comment if this is incorrect.
|
Reporter | |
Updated•14 years ago
|
blocking2.0: --- → ?
OS: Mac OS X → All
Hardware: x86 → All
|
Assignee | |
Comment 1•14 years ago
|
||
The failure actually happens in step 1, which is a regression from bug 543206.
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #467374 -
Flags: review?(gavin.sharp) → review?(mano)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 467374 [details] [diff] [review]
call adjustTabstrip when tabs don't resize anymore, i.e. when the opening animation is done
r=mano
Attachment #467374 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #467374 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #467374 -
Flags: approval2.0? → approval2.0+
|
||
Comment 4•14 years ago
|
||
we should also call adjustTabstrip from pinTab and unpinTab
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #4)
> we should also call adjustTabstrip from pinTab and unpinTab
Good point. Deserves a separate bug.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
|
||
Updated•14 years ago
|
blocking2.0: ? → betaN+
|
||
Comment 7•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre
Do we have any test coverage here?
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
|
|
Assignee | |
Comment 8•14 years ago
|
||
(In reply to comment #7)
> Do we have any test coverage here?
We don't, currently.
You need to log in
before you can comment on or make changes to this bug.
Description
•