Closed
Bug 585789
Opened 14 years ago
Closed 14 years ago
Make Mozmill-test testSearchSelection local
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u279076, Assigned: u279076)
References
Details
(Whiteboard: [litmus-data])
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
whimboo
:
review-
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
u279076
:
review+
whimboo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
aaronmt
:
review+
|
Details | Diff | Splinter Review |
Module: testSearch/testSearchSelection.js
Test-page: Use any 1 page from test-files/layout/mozilla*
Attachment #464966 -
Flags: review?(aaron.train)
|
||
Updated•14 years ago
|
Attachment #464966 -
Flags: review?(aaron.train) → review+
Attachment #464966 -
Flags: review?(hskupin)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 464966 [details] [diff] [review]
Patch v1 (default)
> var setupModule = function(module)
> {
> controller = mozmill.getBrowserController();
nit: please also fix the opening brackets for functions.
>- controller.waitForEval("subject.hasNewTabOpened == true", gTimeout, 100,
>+ controller.waitForEval("subject.hasNewTabOpened == true", TIMEOUT, 100,
> {hasNewTabOpened: tabs.length == (tabCount + 1)});
The comparison has to be part of the expression string otherwise it will timeout. Could be the reason why this test fails some times.
>- controller.waitForEval("subject.isNewBackgroundTab == true", gTimeout, 100,
>+ controller.waitForEval("subject.isNewBackgroundTab == true", TIMEOUT, 100,
> {isNewBackgroundTab: tabs.selectedIndex == tabIndex});
> tabs.selectedIndex = tabs.selectedIndex + 1;
> } else {
>- controller.waitForEval("subject.isNewForegroundTab == true", gTimeout, 100,
>+ controller.waitForEval("subject.isNewForegroundTab == true", TIMEOUT, 100,
> {isNewForegroundTab: tabs.selectedIndex == tabIndex + 1});
Same for those two waitForEval calls.
Attachment #464966 -
Flags: review?(hskupin) → review-
Attachment #464966 -
Attachment is obsolete: true
Attachment #465879 -
Flags: review?(hskupin)
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 465879 [details] [diff] [review]
Patch v2 (default)
>- controller.waitForEval("subject.hasNewTabOpened == true", gTimeout, 100,
>- {hasNewTabOpened: tabs.length == (tabCount + 1)});
>+ controller.waitForEval("subject.tabs.length == subject.expectedCount", TIMEOUT, 100,
>+ {tabs: controller.tabs, expectedCount: tabCount + 1});
Sorry, haven't seen this in our conversation but we do not want to have controller.tabs here. tabs is the tabBrowser instance. Same applies to the other waitForEval functions.
Attachment #465879 -
Flags: review?(hskupin) → review-
|
|
||
Comment 5•14 years ago
|
||
cleanup + chooses better object names in your eval expressions
Attachment #478102 -
Flags: review?(anthony.s.hughes)
Attachment #478102 -
Flags: review?(hskupin)
Attachment #478102 -
Flags: review?(anthony.s.hughes)
Attachment #478102 -
Flags: review+
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 478102 [details] [diff] [review]
Patch v3 - (default)
>+ controller.waitForEval("subject.tabCount == subject.expectedCount", TIMEOUT, 100,
>+ {tabCount: tabs.length,
>+ expectedCount: tabCount + 1});
[..]
>+ controller.waitForEval("subject.selectedTabIndex == subject.expectedIndex", TIMEOUT, 100,
>+ {selectedTabIndex: tabs.selectedIndex,
>+ expectedIndex: tabIndex});
[..]
>+ controller.waitForEval("subject.selectedTabIndex == subject.expectedIndex", TIMEOUT, 100,
>+ {selectedTabIndex: tabs.selectedIndex,
>+ expectedIndex: tabIndex + 1});
> }
>
> controller.waitForPageLoad();
JSON like indentation please. With that r=me.
Attachment #478102 -
Flags: review?(hskupin) → review+
|
|
||
Comment 7•14 years ago
|
||
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
Attachment #478259 -
Flags: review+
(In reply to comment #7)
> Created attachment 478259 [details] [diff] [review]
> Patch v3.1 - (default) [indent fix]
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/9bc13debd150 [default]
http://hg.mozilla.org/qa/mozmill-tests/rev/72279187a64b [mozilla1.9.2]
http://hg.mozilla.org/qa/mozmill-tests/rev/0acdd6d67eb9 [mozilla1.9.1]
Keywords: checkin-needed
NOTE: This test is not 100% local as it relies on performing third-party searches (ie. Wikipedia, EBay). Calling it FIXED for now.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•14 years ago
|
||
(In reply to comment #9)
> NOTE: This test is not 100% local as it relies on performing third-party
> searches (ie. Wikipedia, EBay). Calling it FIXED for now.
Huh, which part of the test?
|
|
||
Comment 11•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•