Ed Lee :Mardak Reporter
	Description • 14 years ago

Bug 586147 adds storing and restoring of the hidden attribute on tabs. Bug 480148 added logic to show visible tabs before those that aren't visible (on the tab strip).

Restoring hidden tabs before visible ones doesn't make sense as the user won't see the page anyway -- it won't even show in the tab strip!

	Paul O'Shannessy [:zpao] (not bugmail, email directly)
	Comment 1 • 14 years ago

blocking2.0? because this is technically a regression (caught in review, but it was considered minor enough to expedite the landing of tab candy).

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 2 • 14 years ago

I think we'll want to pull this back into a Beta, actually.

	dwitte@gmail.com Assignee
	Comment 3 • 14 years ago

zpao, should this be assigned to you? If it being unassigned isn't a mistake, then I'll yoink it.

	Paul O'Shannessy [:zpao] (not bugmail, email directly)
	Comment 4 • 14 years ago

Nope I'm not taking this, but you can. It has a lot of overlap with bug 588217 and bug 586068 though. Probably best to get the quick fix in and just update patches in those other bugs if need be.

	dwitte@gmail.com Assignee
	Comment 5 • 14 years ago

Piece of cake.

	Paul O'Shannessy [:zpao] (not bugmail, email directly)
	Comment 6 • 14 years ago

Comment on attachment 469657 [details] [diff] [review]
patch

thanks dr. witte!

	dwitte@gmail.com Assignee
	Comment 7 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/118b011d4d52

	u88484
	Comment 8 • 14 years ago

Verified fixed 

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100827 Firefox/4.0b5pre

I opened a bunch of tabs where the visible ones take a long time to load while the hidden ones take a very short time to load.  I waited about 10 seconds and while the two slow loading visible ones were still loading I scrolled down the tabbar and witnesses the fast loading hidden ones were still loading (most likely just started because they finished very quickly).