Stefan [:stefanh] Reporter
	Description • 14 years ago

STR:

1) Use a Mac, launch SeaMonkey
2) Close all windows
3) From the Bookmarks menu, choose "Manage Bookmarks"

Expected results: Bookmarks Manager window opens.
Actual results: No window appear and the following error messages can be seen in the error console:

--------------------------------------
Error: PlacesMenu is not defined
Source File: chrome://navigator/content/hiddenWindow.xul
Line: 1
--------------------------------------
Error: PlacesCommandHook is not defined
Source File: chrome://navigator/content/hiddenWindow.xul
Line: 1
--------------------------------------

	Stefan [:stefanh] Reporter
	Comment 1 • 14 years ago

It appears that hiddenWindow.xul still references the old js files, so no menu commands works. I also think that we need to reference the jsm modules in hiddenwindow.

	Robert Kaiser Assignee
	Comment 2 • 14 years ago

Oops, I'm sorry. Somehow I have a tendency to forget that hidden window. :(

	Robert Kaiser Assignee
	Comment 3 • 14 years ago

Stefan, please test this, I hope it works.

	Stefan [:stefanh] Reporter
	Comment 4 • 14 years ago

Comment on attachment 468178 [details] [diff] [review]
v1: I hope that does it

OK, so the BM opens now, but there are a few issues:

1) The first one is a js error while opening the window:
Error: PlacesUtils is not defined
Source File: chrome://communicator/content/places/browserPlacesViews.js
Line: 76

2) The second one is that the bookmarks menu doesn't show any bookmarks while opening it from the menubar (I only see the default menuitems and the PT menu without any bookmarks in and I got a lot of BM)

I suspect that 2) is related to the jsm modules I mention in comment #1, but I'm not sure.

	Robert Kaiser Assignee
	Comment 5 • 14 years ago

OK, I guess we need to add the places overlay as well.

	Stefan [:stefanh] Reporter
	Comment 6 • 14 years ago

It works now, but I get an error in the console saying:
------------------------------------------------------------------
Error: An error occurred updating the cmd_selectAll command: [Exception... "'[JavaScript Error: "this._view.result is null" {file: "chrome://communicator/content/places/controller.js" line: 181}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 55"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 61
------------------------------------------------------------------

	Stefan [:stefanh] Reporter
	Comment 7 • 14 years ago

Not sure that's related, though...

	Stefan [:stefanh] Reporter
	Comment 8 • 14 years ago

Actually, the error in comment #6 happens on non-mac as well. I have however found another problem - it seems that the microsummaryservice seems to relies on that you have a browser window open

Error: event is not defined
Source File: file:///Users/Stefan/objdir-sm-trunk/mozilla/dist/SeaMonkeyDebug.app/Contents/MacOS/components/nsMicrosummaryService.js
Line: 1982

	Stefan [:stefanh] Reporter
	Comment 9 • 14 years ago

this happens btw while selecting a bookmark in the bm.

	Robert Kaiser Assignee
	Comment 10 • 14 years ago

(In reply to comment #9)
> this happens btw while selecting a bookmark in the bm.

Please file a new bug for that, either bad port or failure from addressing reviews.

Let's keep this bug to making hiddenWindow work - and I'm happy if we can succeed there.

	Stefan [:stefanh] Reporter
	Comment 11 • 14 years ago

Comment on attachment 469646 [details] [diff] [review]
v1.1: add the overlay

> Please file a new bug for that, either bad port or failure from addressing
> reviews.
Sure, we can do that in another bug.

	Stefan [:stefanh] Reporter
	Comment 12 • 14 years ago

(In reply to comment #11)
> Comment on attachment 469646 [details] [diff] [review]
> v1.1: add the overlay
> 
> > Please file a new bug for that, either bad port or failure from addressing
> > reviews.
> Sure, we can do that in another bug.
Filed bug 586363.

	Stefan [:stefanh] Reporter
	Comment 13 • 14 years ago

(In reply to comment #12)
> Filed bug 586363.

Uh, I mean bug 591807.

	Robert Kaiser Assignee
	Comment 14 • 14 years ago

Pushed as http://hg.mozilla.org/comm-central/rev/e2155ffb330a - thanks for bringing it up!