Closed
Bug 586607
Opened 14 years ago
Closed 14 years ago
BuildContentLists should allocate contentList after getting parent
Categories
(Core :: XBL, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
jst
:
approval2.0-
|
Details | Diff | Splinter Review |
// XXX Could this array just be altered in place and passed directly to
// SetContentListFor? We'd save space if we could pull this off.
nsInsertionPointList* contentList = new nsInsertionPointList;
if (!contentList) {
data->mRv = NS_ERROR_OUT_OF_MEMORY;
return PL_DHASH_STOP;
}
// Figure out the relevant content node.
nsXBLInsertionPoint* currPoint = aData->ElementAt(0);
nsCOMPtr<nsIContent> parent = currPoint->GetInsertionParent();
if (!parent) {
data->mRv = NS_ERROR_FAILURE;
leaks contentList:
return PL_DHASH_STOP;
}
PRInt32 currIndex = currPoint->GetInsertionIndex();
|
||
Comment 2•14 years ago
|
||
Comment on attachment 465181 [details] [diff] [review]
patch
Patch could have used a bigger -U (5 or so)
Attachment #465181 -
Flags: review?(neil) → review+
Attachment #465181 -
Flags: approval2.0?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 465181 [details] [diff] [review]
patch
Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #465181 -
Flags: approval2.0? → approval2.0-
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•