Closed
Bug 586610
Opened 14 years ago
Closed 9 years ago
Could not read extensions chrome manifest file (972ce4c6-7e08-4474-a285-3208198ce6fd = default theme)
Categories
(Toolkit :: Add-ons Manager, defect, P5)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
People
(Reporter: Nomis101, Unassigned)
References
Details
Attachments
(2 obsolete files)
Since the changes from Bug 579178, I see the following message in TBs error console:
Could not read chrome manifest file '/Volumes/Shredder/Shredder.app/Contents/MacOS/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest'.
This extensions is the Thunderbird default theme.
Same on today's Windows nightly, identical uuid.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment 2•14 years ago
|
||
Is Firefox doing this as well? My bet is that it is.
If so, this should possibly be a toolkit bug unless the decision is to create empty chrome.manifest or something.
Oh yes, you are right, Firefox is doing this as well:
Could not read chrome manifest file '/Volumes/Minefield/Minefield.app/Contents/MacOS/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest'.
So I will change this bug into a toolkit bug.
Updated•14 years ago
|
Component: General → Themes
Product: Thunderbird → Toolkit
QA Contact: general → themes
Oh yes, you are right, Firefox is doing this as well:
Could not read chrome manifest file '/Volumes/Minefield/Minefield.app/Contents/MacOS/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest'.
So I will change this bug into a toolkit bug.
Component: Themes → Add-ons Manager
QA Contact: themes → add-ons.manager
Comment 5•14 years ago
|
||
It's kind of noisy yes. We'd either have to create an empty manifest for the theme (which would cause a bit of useless work during startup), or turn this error off maybe just for that directory. What do you think benjamin?
Comment 6•14 years ago
|
||
Yeah, I'm not sure where the right place is to turn this off, but I definitely don't want the noise. I think that if you call XRE_AddManifestLocation, we should warn if the manifest doesn't exist. So maybe we should have a special case (like em:nomanifest) for the default theme?
Comment 7•14 years ago
|
||
Oh yeah I guess we can do this from the EM side by not putting it into extensions.ini in the first place. Using a special instruction like that is possible, though we may end up caching it in a pref since otherwise we'd have to stick it into the database which is a bit pointless for one theme.
Maybe we should just look for a extensions.nomanifest.<id> preference that the app can set or something.
Updated•14 years ago
|
blocking2.0: --- → final+
Comment 8•14 years ago
|
||
We can just not put it into extensions.ini if the theme's internalname is equal to the default skin name.
Whiteboard: [good first bug]
Comment 9•14 years ago
|
||
Annoying but now we're hiding the error console this doesn't block I think.
blocking2.0: final+ → -
Comment 10•14 years ago
|
||
(In reply to comment #9)
> Annoying but now we're hiding the error console this doesn't block I think.
But we aren't on non FF products :-(
Comment 11•14 years ago
|
||
(In reply to comment #10)
> (In reply to comment #9)
> > Annoying but now we're hiding the error console this doesn't block I think.
>
> But we aren't on non FF products :-(
And if you want to provide a patch then I'll review and approve it for landing
Reporter | ||
Comment 12•14 years ago
|
||
I can make a patch that will put a empty chrome.manifest into the folder /extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}. Would this be a acceptable solution? The downside of this is, you need such a patch for each application (FF, TB, SM) and for each OS. The upside is, I can make a patch and it works.
It would definitely be a smarter solution to solve this in the way Benjamin or Dave suggested, but I can't make a patch for that. :-(
Updated•14 years ago
|
Blocks: 598328
Summary: Could not read extensions chrome manifest file → Could not read extensions chrome manifest file (972ce4c6-7e08-4474-a285-3208198ce6fd = default theme)
Updated•14 years ago
|
Updated•14 years ago
|
Reporter | ||
Comment 14•14 years ago
|
||
Because it seems this will not be fixed in Gecko 2.0, I've made this workaround patch for Thunderbird. This patch places an empty file chrome.manifest into /extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/ on Windows, Mac and Linux. This fixed this noise for me. I can do the same for suite as well.
Attachment #514079 -
Flags: review?(bugzilla)
Comment 15•14 years ago
|
||
Comment on attachment 514079 [details] [diff] [review]
Workaround patch for Thunderbird
Whilst this is fine, I'd prefer it on a Thunderbird specific bug so that we have tracking of it in the Thunderbird product. Therefore I've moved this patch across to bug 654672.
Attachment #514079 -
Attachment is obsolete: true
Attachment #514079 -
Flags: review?(mbanner)
Comment 16•13 years ago
|
||
Confirmed with Firefox 6.0 - Windows XP SP3:
Could not read chrome manifest file 'C:\Program Files\Mozilla Firefox\extensions\{972ce4c6-7e08-4474-a285-3208198ce6fd}\chrome.manifest'.
[Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20100101 Firefox/6.0]
This warning was for me first issued with Firefox 4.0.1 (late upgrade from FF 3.6.17 in June 2011).
Comment 18•13 years ago
|
||
The same fix as http://hg.mozilla.org/comm-central/rev/11953f14423a for m-c.
Attachment #569066 -
Flags: review?
Updated•13 years ago
|
Attachment #569066 -
Flags: review? → review?(mbanner)
Comment 19•13 years ago
|
||
Comment on attachment 569066 [details] [diff] [review]
fix
If Firefox (too) wants this workaround, I would suggest to un-duplicate bug 671515 and use it, as this bug is for a "Toolkit" fix.
Updated•13 years ago
|
Attachment #569066 -
Attachment is obsolete: true
Attachment #569066 -
Flags: review?(mbanner)
Comment 20•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #19)
> If Firefox (too) wants this workaround, I would suggest to un-duplicate bug
> 671515 and use it, as this bug is for a "Toolkit" fix.
Thanks.
I un-duplicate bug 671515 now.
Comment 21•13 years ago
|
||
Going to take care of this in bug 697312 by not including the default theme in extensions.ini
Comment 23•13 years ago
|
||
Note that the about:telemetry addon has this issue as well (no chrome.manifest so it complains).
Comment 24•13 years ago
|
||
Since I saw there was an entry for integrating about:telemetry in bugzilla I went ahead and added an issue for it #700122.
Comment 25•13 years ago
|
||
(In reply to Dave Townsend (:Mossop) from comment #21)
> Going to take care of this in bug 697312 by not including the default theme
> in extensions.ini
[Mozilla/5.0 (Windows NT 5.0; rv:11.0a1) Gecko/20111117 Firefox/11.0a1] (nightly, 2011-11-01-mozilla-central-debug)
Error still there,
as expected:
{
(In reply to Dave Townsend (:Mossop) from bug 697312 comment 14)
> I've just abandoned the fix for bug 586610 for now.
}
No longer depends on: 697312
Comment 26•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #25)
> [Mozilla/5.0 (Windows NT 5.0; rv:11.0a1) Gecko/20111117 Firefox/11.0a1]
> (nightly, 2011-11-01-mozilla-central-debug)
Nit:
[Mozilla/5.0 (Windows NT 5.0; rv:11.0a1) Gecko/20111117 Firefox/11.0a1] (nightly, 2011-11-17-03-09-39-mozilla-central)
Comment 27•12 years ago
|
||
confirmed with Firefox release (16.0.2) till nightly (19.0a1)
With a clean new profile the error console should be empty after starting Firefox.
Sadly, at the moment there are some different error messages.
I think together with the QA team this should be monitored/fixed before a new release build goes public.
Thanks
Comment 28•12 years ago
|
||
MrX, this isn't an especially important bug (there are no ill user effects). So you are welcome to take it and provide a patch, but please don't think that we're going to hold any releases on it.
Comment 29•11 years ago
|
||
Benjamin, do you think is this still valid or it could be set as RESOLVED WONTFIX?
Flags: needinfo?(benjamin)
Comment 30•11 years ago
|
||
If it still occurs, it is valid.
Flags: needinfo?(benjamin)
Priority: -- → P5
Comment 31•11 years ago
|
||
The original error is gone, but with I now see the following warning message in Thunderbird 17.0.6 due to the empty chrome.manifest:
Warning: WARN addons.updates: Update manifest for {972ce4c6-7e08-4474-a285-3208198ce6fd} did not contain an updates property
Source file: resource://app/modules/AddonUpdateChecker.jsm
Line: 318
Comment 32•11 years ago
|
||
Hmz. The new warning probably doesn't come from the empty chrome.manifest, but from an empty update.rdf on amo or something like that?
Comment 33•11 years ago
|
||
That is a different bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Comment 34•10 years ago
|
||
WFM ??
Not here. Linux, FF 33.
Could not read chrome manifest 'file:///usr/lib/firefox/browser/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/chrome.manifest
Guess you were a little hasty in tagging this WFM.
Comment 35•10 years ago
|
||
This is definitely still happening. If adding the empty chrome.manifest doesn't affect Talos, can we just do that simple solution (the other popular Gecko apps have already done this).
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Reporter | ||
Comment 36•10 years ago
|
||
It was fixed, but since some time it is happening again. See Bug 1116223 for the TB issue.
Comment 37•10 years ago
|
||
(In reply to Nomis101 from comment #36)
> It was fixed, but since some time it is happening again. See Bug 1116223 for
> the TB issue.
It is not "some time". It happens at each startup from Firefox 4 (see comment #16). For example, with latest official release [User Agent: Mozilla/5.0 (Windows NT 5.1; rv:35.0) Gecko/20100101 Firefox/35.0]:
14:09:00,251 Could not read chrome manifest 'file:///C:/Program%20Files/Mozilla%20Firefox/chrome.manifest'.
[...]
14:09:00,612 Could not read chrome manifest 'file:///C:/Program%20Files/Mozilla%20Firefox/browser/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/chrome.manifest'.
To note also the first message about 'C:/Program Files/Mozilla Firefox/chrome.manifest', at least from Firefox 23, or earlier: Firefox 21? or 22? (for these 2 last, I do not have full logs).
Comment 38•10 years ago
|
||
(In reply to Blutin from comment #37)
> To note also the first message about 'C:/Program Files/Mozilla
> Firefox/chrome.manifest', at least from Firefox 23, or earlier: Firefox 21?
> or 22? (for these 2 last, I do not have full logs).
According to bug 865348, it is from April 24, 2013 Nightly 23.
Comment 39•9 years ago
|
||
This was fixed in Firefox by bug 1150417
Status: REOPENED → RESOLVED
Closed: 11 years ago → 9 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Comment 40•8 years ago
|
||
FYI message
Could not read chrome manifest 'file///Volumes/DATA/dgerman/.bin/Thunderbird.app/Contents/Resources/chrome.manifest'.
and
Could not read chrome manifest 'jar:file:///Volumes/DATA/dgerman.bin/Thunderbird.app/Contents/Resources/extensions/%7B972ce4c67e08-4474-a285-3208198ce6fd%7D.xpi!/chrome.manifest'.
Occurs on Mac OS X 10.11.5 Thunderbird 45.1.1
Comment 41•8 years ago
|
||
I have discovered
5331 Jun 2 20:39 chrome.manifest
1030065 Jun 2 20:39 chrome.jar
in the directory
Thunderbird.app/Contents/Resources/distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}
You need to log in
before you can comment on or make changes to this bug.
Description
•