Danny Moules Reporter
	Description • 14 years ago

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3) Gecko/20100805 Firefox/4.0b3
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3) Gecko/20100805 Firefox/4.0b3

WebGL's VIEWPORT enum is not implemented, resulting in an OpenGL 'Invalid Enum' error.

Reproducible: Always

Steps to Reproduce:
1. Where gl represents a WebGL context:
2. Execute javascript: var arrViewport = gl.getParameter(gl.VIEWPORT);
Actual Results:  
Javascript exception is thrown and WebGL throws and gl.getError() returns gl.INVALID_ENUM.

Expected Results:  
arrViewport represents a four-element Int32 array.

Request was made from an extension dialog.

	Benoit Jacob [:bjacob] (mostly away)
	Comment 1 • 14 years ago

yes, we know about this problem.

The real problem is that there already is a function, gl.viewport(). And we have trouble with identifiers that only differ by case. But Vlad's working on this.

	Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond) Assignee
	Comment 2 • 14 years ago

Yep, it's currently VIEWPORT_RECT, but at some point this will be fixed.  In the meantime you could use the actual hex value (0x0BA2) and get the same behaviour on all browsers.. ugly, but would work.

	Joe Drew (not getting mail)
	Comment 3 • 14 years ago

Vlad, do we have any chance of actually fixing this in a world involving xpidl?

	Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond) Assignee
	Comment 5 • 14 years ago

Ended up being a lot simpler than I feared.  Thanks to mrbkap for the pointers!

	Blake Kaplan (:mrbkap) (inactive)
	Comment 6 • 14 years ago

Comment on attachment 498897 [details] [diff] [review]
finally

It would be better to detect failure from JS_DefineProperty and return NS_ERROR_FAILURE or something similar in that case. Looks good otherwise.

	Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond) Assignee
	Comment 7 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/3a72f8d24d43 finally.