Closed Bug 587039 Opened 14 years ago Closed 14 years ago

Rename View > TabView And All Instances of Tab Sets to "Group my tabs..."

Categories

(Firefox Graveyard :: Panorama, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b4

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file, 3 obsolete files)

We're calling tabcandy "Tab Sets", and I think the View menu entry should reflect that.
Attached patch Patch (v1) (obsolete) (deleted) — Splinter Review
Attachment #465676 - Flags: review?(dolske)
So Tabcandy==Tab Sets? Are the tab sets I see in Tabcandy tab sets, then? Or are they called tab groups?
Aza said to hold off on giving it an official user facing name and just describe the functionality. "Organize your tab groups" instead of something like "Open Tab Sets"
Blocks: 586788
Whiteboard: b4
Priority: -- → P2
I think we need to make a call here before beta4.
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
For b4 we are staying away from in-product branding (so yes, that does mean I'll have to update the video, but that can happen outside of the Firefox beta release schedule). Marketing is helping us come up with a name but that will take until early next week (after string freeze). Thus, the menu should say "Organize your tabs..." The tooltip should say the same thing for hovering on the Tab Candy button. (With the os-apropos keyboard shortcut).
Summary: Rename View > TabView to "Tab Sets" → Rename View > TabView And All Instances of Tab Sets to "Organize your tabs..."
Mayumi suggests "Group your tabs..." which is more direct and shorter. Let's go with that.
Summary: Rename View > TabView And All Instances of Tab Sets to "Organize your tabs..." → Rename View > TabView And All Instances of Tab Sets to "Group your tabs..."
Final iteration "Group my tabs..."
Summary: Rename View > TabView And All Instances of Tab Sets to "Group your tabs..." → Rename View > TabView And All Instances of Tab Sets to "Group my tabs..."
Attached patch Patch (v2) (obsolete) (deleted) — Splinter Review
This should land today if it's going to make beta4.
Attachment #465676 - Attachment is obsolete: true
Attachment #465859 - Flags: review?(dolske)
Attachment #465676 - Flags: review?(dolske)
Attached patch Patch (v3) (obsolete) (deleted) — Splinter Review
With changes to the title of the tab candy window.
Attachment #465859 - Attachment is obsolete: true
Attachment #465865 - Flags: review?(dolske)
Attachment #465859 - Flags: review?(dolske)
Attachment #465865 - Flags: review?(dolske)
Attached patch Patch v4 (deleted) — Splinter Review
Attachment #465865 - Attachment is obsolete: true
Attachment #465897 - Flags: review?(dolske)
Comment on attachment 465897 [details] [diff] [review] Patch v4 >-<!ENTITY tabViewButton.label "Tab Sets"> >-<!ENTITY tabViewButton.tooltip "Open a visual tab interface"> >+<!ENTITY tabViewButton2.label "Group Your Tabsâ¦"> >+<!ENTITY tabViewButton2.tooltip "Group Your Tabsâ¦"> Nit: the label should be a smaller string -- "Tab Groups" -- and the tooltip shouldn't have the trailing ellipsis. r+ with that.
Attachment #465897 - Flags: review?(dolske)
Attachment #465897 - Flags: review+
Attachment #465897 - Flags: approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: b4
Target Milestone: --- → Firefox 4.0b4
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
-tabView.title=%S Tab Sets +tabView2.title=%S - Group Your Tabs Care to explain what is that variable? Please add useful localization comments when you commit new strings.
Also, "Group Your Tabs" can have a much better name than tabView2, using numeric increments is generally the least good option.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Blocks: 587518
(In reply to comment #14) > -tabView.title=%S Tab Sets > +tabView2.title=%S - Group Your Tabs > > Care to explain what is that variable? Please add useful localization comments > when you commit new strings. This is for the window title while the Tab Candy UI is up. The %s becomes the application name, so it'll be "Firefox - Group Your Tabs".
(In reply to comment #15) > Also, "Group Your Tabs" can have a much better name than tabView2, using > numeric increments is generally the least good option. I was told we need to add a number to indicate to the localization team that it was a substantive change (rather than just fixing a typo). Is this not true? Is there a better way?
Ian, mind dropping me a mail who said so, might be good to do some focused messaging there. In general, string names should be "good variable names" in a "good programming" sense, and foo2 is obviously not. Sometimes we're between a rock and a hard place, where there's no good new name, in which case, rev'ing the entity name with a number is the last resort. But in this case "groupYourTabs" would have been a much better name than tabView, or tabView2.
Depends on: 595939
(In reply to comment #19) > Ian, mind dropping me a mail who said so, might be good to do some focused > messaging there. > > In general, string names should be "good variable names" in a "good > programming" sense, and foo2 is obviously not. Sometimes we're between a rock > and a hard place, where there's no good new name, in which case, rev'ing the > entity name with a number is the last resort. But in this case "groupYourTabs" > would have been a much better name than tabView, or tabView2. I actually don't remember who it was. Anyway, I agree that it did not have a good name to begin with. If it did have an ideal name, however, then I should add a number to it if the phrase needs retranslating but the meaning of the variable hasn't changed? Seems wrong to change the variable name to something substandard just to avoid adding a number.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: