Closed
Bug 587299
Opened 14 years ago
Closed 14 years ago
Investigate Ts Shutdown regression (MIN Dirty Profile increase 6.38% on MacOSX 10.5.8 Firefox)
Categories
(Firefox :: Session Restore, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b4
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: perf, regression)
Attachments
(1 file)
|
(deleted),
patch
|
dietrich
:
review+
dietrich
:
approval2.0+
|
Details | Diff | Splinter Review |
> Regression: Ts Shutdown, MIN Dirty Profile increase 6.38% on MacOSX 10.5.8 Firefox
> Previous results:
> 132.053 from build 20100813041754 of revision 29114207a571 at 2010-08-13 05:25:08 on talos-r3-leopard-016 run # 0
> New results:
> 140.474 from build 20100813054859 of revision 69e2e34ccddc at 2010-08-13 06:14:04 on talos-r3-leopard-021 run # 0
> http://mzl.la/d3ZnEi
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=29114207a571&tochange=69e2e34ccddc
Bug 580512 seems like the likely culprit, we might be doing unnecessary work when collecting the session data.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #466085 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 466085 [details] [diff] [review]
tighten scope when collecting data for pinned tabs
looks good, r+a=me.
Attachment #466085 -
Flags: review?(dietrich)
Attachment #466085 -
Flags: review+
Attachment #466085 -
Flags: approval2.0?
Attachment #466085 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #466085 -
Attachment description: tighten scope when collecting data for pinned tab → tighten scope when collecting data for pinned tabs
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b4
|
|
Assignee | |
Updated•14 years ago
|
Keywords: regression
|
||
Comment 4•14 years ago
|
||
Did we see this regression go away?
|
|
Assignee | |
Comment 5•14 years ago
|
||
I haven't seen an e-mail about it. Is this thing represented somewhere on <http://graphs.mozilla.org/dashboard/?tree=Firefox>?
|
|
||
Comment 6•14 years ago
|
||
(In reply to comment #5)
> I haven't seen an e-mail about it. Is this thing represented somewhere on
> <http://graphs.mozilla.org/dashboard/?tree=Firefox>?
No, you'll have to look at the graphs. If this didn't fix it, we should back out this and the original changeset to see if the regression goes away to make sure that it properly identified the cause.
|
|
Assignee | |
Comment 7•14 years ago
|
||
(In reply to comment #6)
> No, you'll have to look at the graphs.
I can't, it's unusable for me. It won't draw graphs.
|
|
||
Comment 8•14 years ago
|
||
(In reply to comment #7)
> I can't, it's unusable for me. It won't draw graphs.
Then we either need to do what I said in comment 6, or find someone that the graphs work for.
|
|
Assignee | |
Comment 9•14 years ago
|
||
backed out yesterday:
http://hg.mozilla.org/mozilla-central/rev/341fd55543f9
http://hg.mozilla.org/mozilla-central/rev/173567324591
http://hg.mozilla.org/mozilla-central/rev/8d75a2953b13
http://hg.mozilla.org/mozilla-central/rev/49122e0ed571
relanded today:
http://hg.mozilla.org/mozilla-central/rev/9fd65dc00474
http://hg.mozilla.org/mozilla-central/rev/d675f6410c34
No mail about Ts Shutdown improvements or regressions yet.
You need to log in
before you can comment on or make changes to this bug.
Description
•