Closed
Bug 587320
Opened 14 years ago
Closed 14 years ago
[d2d] TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_painting.html
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta4+ |
People
(Reporter: jrmuizel, Assigned: bas.schouten)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
84338 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_painting.html | partially clipped plugin painted once - got 2, expected 1
84339 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_painting.html | painted after invalidate - got 4, expected 2
Assignee | ||
Comment 1•14 years ago
|
||
With Direct2D on windowless plugins will paint in two passes, so twice as many paint events are to be expected.
Assignee: nobody → bas.schouten
Status: NEW → ASSIGNED
Attachment #466082 -
Flags: review?(jmuizelaar)
Comment 2•14 years ago
|
||
Comment on attachment 466082 [details] [diff] [review]
Expect 2 and 4 painting events for D2D
> function invalidate() {
>- is(clipped.getPaintCount(), 1, "partially clipped plugin painted once");
>+ netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
>+ if (Components.classes["@mozilla.org/gfx/info;1"].getService(Components.interfaces.nsIGfxInfo).D2DEnabled) {
The GfxInfo structure's only available on Windows, so you'll have to wrap this in a try/catch block.
>+ // With D2D we paint windowless plugin with 2 passes, 2 paints are expected.
>+ is(clipped.getPaintCount(), 2, "partially clipped plugin painted once");
Painted twice? Or should we say one because it's logically one?
>+ } else {
>+ is(clipped.getPaintCount(), 1, "partially clipped plugin painted once");
>+ }
> function done() {
>- is(clipped.getPaintCount(), 2, "painted after invalidate");
>+ netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
>+ if (Components.classes["@mozilla.org/gfx/info;1"].getService(Components.interfaces.nsIGfxInfo).D2DEnabled) {
Same problem - wrap in try/catch.
Attachment #466082 -
Flags: review?(jmuizelaar) → review-
Updated•14 years ago
|
blocking2.0: --- → beta4+
Assignee | ||
Comment 3•14 years ago
|
||
Updated.
Attachment #466082 -
Attachment is obsolete: true
Attachment #466215 -
Flags: review?(joe)
Assignee | ||
Updated•14 years ago
|
Attachment #466215 -
Attachment is patch: true
Attachment #466215 -
Attachment mime type: application/octet-stream → text/plain
Comment 4•14 years ago
|
||
Comment on attachment 466215 [details] [diff] [review]
Expect 2 and 4 painting events for D2D v2
much better!
Attachment #466215 -
Flags: review?(joe) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•