Masatoshi Kimura [:emk] Assignee
	Description • 14 years ago

Japanese MSVC compiler prefixes "メモ: インクルード ファイル:" instead of "Note: including file:". cl.py do not handle this correctly.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 1 • 14 years ago

Oh man, this is going to be fun.

	Masatoshi Kimura [:emk] Assignee
	Comment 2 • 14 years ago

Workaround: chcp.com 437

	(not currently active) Ted Mielczarek
	Comment 4 • 14 years ago

Comment on attachment 466114 [details] [diff] [review]
Make prefix string configurable

I'd rather not turn cl.py into a preprocessed file. How about you just AC_SUBST that value, then cl.py can read it as an environment variable (with the default being what it currently is)?

Also, I hate that Microsoft localizes their compiler output.

	Masatoshi Kimura [:emk] Assignee
	Comment 5 • 14 years ago

> Also, I hate that Microsoft localizes their compiler output.
We can do nothing about that :(

	Masatoshi Kimura [:emk] Assignee
	Comment 6 • 14 years ago

The magic number 21 also needs to be changed.

	(not currently active) Ted Mielczarek
	Comment 7 • 14 years ago

Comment on attachment 472141 [details] [diff] [review]
Using an environment variable v2

It might be nice if we could figure out from the version check we already do in configure if this test is necessary. (Can we figure out if we're using an en-US compiler from just the "cl.exe -help" text?)

But this is fine, anyway.

	Masatoshi Kimura [:emk] Assignee
	Comment 8 • 14 years ago

This is very important for non-English developers to build the tree correctly.

(In reply to comment #7)
> It might be nice if we could figure out from the version check we already do in
> configure if this test is necessary. (Can we figure out if we're using an en-US
> compiler from just the "cl.exe -help" text?)
I'd file a followup bug.

	David Baron :dbaron:
	Comment 9 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/fa73c5362474

I'm not sure whether I should mark this bug fixed now, so I'm leaving it.

	Masatoshi Kimura [:emk] Assignee
	Comment 10 • 14 years ago

I observed that dependencies are correctly resolved on Japanese locale.
Console does no loner spit out garbages. Marking FIXED.

	Masatoshi Kimura [:emk] Assignee
	Comment 11 • 14 years ago

(In reply to comment #8)
> > It might be nice if we could figure out from the version check we already do in
> > configure if this test is necessary. (Can we figure out if we're using an en-US
> > compiler from just the "cl.exe -help" text?)
> I'd file a followup bug.
Filed bug 600788.