Closed
Bug 587483
Opened 14 years ago
Closed 14 years ago
warning: comparison between signed and unsigned integer expressions in FrameLayerBuilder
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
layout/base/FrameLayerBuilder.cpp:
In member function ‘void mozilla::<unnamed>::ContainerState::ProcessDisplayItems(const nsDisplayList&, const nsRect*)’:
923: warning: comparison between signed and unsigned integer expressions
In static member function ‘static void mozilla::FrameLayerBuilder::DrawThebesLayer(mozilla::layers::ThebesLayer*, gfxContext*, const nsIntRegion&, const nsIntRegion&, void*)’:
1371: warning: comparison between signed and unsigned integer expressions
i don't know why AppUnitsPerDevPixel are signed in our codebase and i don't really care. this is the simplest path to a warning free file.
Attachment #466151 -
Flags: review?(roc) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
Attachment #466151 -
Flags: approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•