Open Bug 58788 Opened 24 years ago Updated 2 years ago

xul text-decoration isn't quite working on unix (and mac and win32)

Categories

(Core :: XUL, defect, P3)

defect

Tracking

()

REOPENED
Future

People

(Reporter: pete, Unassigned)

References

()

Details

(Keywords: helpwanted, Whiteboard: [rtm-])

Attachments

(2 files)

text-decoration : underline; Doesn't work on unix. it works fine on windows . . . --pete
Yes, this is on the branch . . .
Keywords: rtm
Um... do you have a testcase? It seems to be working for me on Linux. Try this testfile: <p style="text-decoration:underline">This should be underline</p>
It is not working in a xul button. I will create a test case tomorrow. --pete
Hmm, I'll reassign this to XUL then.
Assignee: clayton → trudelle
Component: Layout → XP Toolkit/Widgets: XUL
QA Contact: petersen → jrgm
Try this: <text value="wheres the beef" style="text-decoration:underline;" /> It is a xul issue . . . --pete
Actually, support for text-decoration is mixed on all platforms (none work on linux, overline/line-through map to underline on Mac, overline doesn't work on win32, and, oh no! -- blink doesn't work anywhere :-] <?xml version="1.0"?> <?xml-stylesheet href="chrome://global/skin/" type="text/css"?> <window xmlns:html="http://www.w3.org/TR/REC-html40" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"> <button value="am i underlined" style="text-decoration:underline;" /> <button value="am i overlined" style="text-decoration:overline;" /> <button value="am i blink" style="text-decoration:blink;" /> <button value="am i line-through" style="text-decoration:line-through;" /> </window>
Summary: text-decoration isn't working on unix → text-decoration isn't working on unix (and mac and win32)
John, i distinctly remember underline working on unix. Maybe it was M8 or M9 but it did work at one time . . . So i guess you guys are already aware of this. ;-) --pete
This is for XUL only, right? Do we really think this is an RTM blocker? I strongly recommend rtm-. We have some way higher reward CSS bugs that are -.
Yes, this is only for XUL as far as I know. (A brief test says that for the P element, mac/linux/win32, the values underline/overline/line-through/blink work individually and in combinations). And, I'll skip a step and mark this [rtm-] -- any fix for this would not be a one-liner, and those are the only thing that would ever be accepted (if at all) for a cosmetic defect. Sorry.
Whiteboard: [rtm-]
just collided in mid-air trying to do this. This clearly doesn't fit the current 'pull it off the wire' criteria. future also
Target Milestone: --- → Future
Status: NEW → ASSIGNED
->hyatt/untargetted
Assignee: trudelle → hyatt
Status: ASSIGNED → NEW
Target Milestone: Future → ---
still Future
Target Milestone: --- → Future
*** Bug 74663 has been marked as a duplicate of this bug. ***
*** Bug 75756 has been marked as a duplicate of this bug. ***
This one (missing underline decoration on Linux only) affects couple of places in the product. 1. mailnews : AccountCentral items 2. mailnews : message header view (from, to, cc fields) 3. aim (nsonly) : Forgot the password link [mentioned ns item only to give an idea of the impact] Will mark bug 67711 as a dup of this one. That bug also has a readuced test case if needed. Nominating this for beta1 (adding nsbeta1 keyword) and adding mailtrack keyword for tracking purposes. Clearing rtm keyword as that was intended for 6.0.
Keywords: rtmnsbeta1
*** Bug 67711 has been marked as a duplicate of this bug. ***
Keywords: mailtrack
If someone can tell me where to look i'll take a stab at implementing this sucker. --pete
It would be great if someone could take a look at this for the reasons that racham mentions. The Acct Central feature on Linux depends on this. I'm changing the severity to a blocker because it blocks this feature (of course, if there are workarounds that anyone knows of, help with that would be great).
Severity: normal → blocker
Putterman, what aspect of the Account Central does it block?
Changing back to normal severity. I had a misunderstanding about how bad this was. Acct Central is useable without the underline. It would be nice to have it, but it's definitely not a blocker.
Severity: blocker → normal
My style system rewrite fixes this I believe anyway.
Status: NEW → ASSIGNED
Blocks: 74357
Works with testcase in bug 67711. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
A few glitches in deciding when to stop drawing the line. Reopening, but still future. <?xml version="1.0"?> <?xml-stylesheet href="chrome://global/skin/" type="text/css"?> <window xmlns:html="http://www.w3.org/TR/REC-html40" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"> <box> <box orient="vertical"> <button label="am i underlined" style="text-decoration:underline;" /> <button label="am i overlined" style="text-decoration:overline;" /> <button label="am i blink" style="text-decoration:blink;" /> <button label="am i line-through" style="text-decoration:line-through;" /> <html style="text-decoration:underline;">am i underlined</html> <html style="text-decoration:overline;">am i overlined</html> <html style="text-decoration:blink;">am i blink</html> <html style="text-decoration:line-through;">am i line-through</html> <tabbox> <tabs> <tab style="text-decoration:underline;" label="am i underlined"/> <tab style="text-decoration:overline;" label="am i overlined"/> <tab style="text-decoration:blink;" label="am i blink"/> <tab style="text-decoration:line-through;" label="am i line-through"/> </tabs> <tabpanels/> </tabbox> </box> </box> </window>
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: text-decoration isn't working on unix (and mac and win32) → text-decoration isn't quite working on unix (and mac and win32)
Blocks: 104166
Blocks: 55623
remove dependency; this isn't html4.0. Try reading a bug report first, eh.
No longer blocks: 55623
Severity: normal → minor
OS: FreeBSD → All
Hardware: PC → All
Summary: text-decoration isn't quite working on unix (and mac and win32) → xul text-decoration isn't quite working on unix (and mac and win32)
Attached file Testcase from comment 23 (deleted) —
As noted in comment 6, this displays as expected in Win32, except that blinking is not supported. Which is just fine with me. Would like to know whether underline/overline/strikethru (at least) are working OK under Mac and Linux.
For some reason the CSS property 'text-decoration' behaves inconsistent in FF2.0.0.12, FF3b2 and XULrunner (1.8.20060.60814). As far I can see, the implementation for 'text-decoration: underline' is wrong: http://www.w3.org/TR/REC-CSS2/text.html#propdef-text-decoration --> "If the element has no content or no text content (e.g., the IMG element in HTML), user agents must ignore this property."
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Assignee: hyatt → nobody
Severity: minor → S4

The severity field for this bug is relatively low, S4. However, the bug has 3 duplicates.
:enndeakin, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(enndeakin)

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Flags: needinfo?(enndeakin)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: