Closed
Bug 588345
Opened 14 years ago
Closed 14 years ago
Fix l10n comments for JS/DOM Object Introspector
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(blocking2.0 -)
RESOLVED
FIXED
Firefox 4.0b5
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: julian.viereck, Assigned: julian.viereck)
References
Details
(Whiteboard: [kd4b5])
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
Pike
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
Hint by Axel Hecht on bug 573102 (Implementing a JS/DOM Object Introspector), comment 99:
> Can you land a follow up to make the localization notes follow the markup on
> https://developer.mozilla.org/en/Localization_notes, i.e.
>
> # LOCALIZATION NOTE (jsPropertyTitle,jsPropertyInspectTitle):...
>
> Most l10n tools don't offer a source view, but there are l10n tools that
> actually parse that format, and understand when to offer the comment.
Will do so.
|
||
Updated•14 years ago
|
Whiteboard: [kd4b5]
|
Assignee | |
Comment 1•14 years ago
|
||
Fixes the i10n notes as requested.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 467104 [details] [diff] [review]
Patch v1
Trivial change, therefore ask directly for review and not feedback at first place.
Attachment #467104 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Requesting blocking status on this bug as it's i10n related and therefore should land before/with b5.
blocking2.0: --- → ?
|
||
Comment 4•14 years ago
|
||
Comment on attachment 467104 [details] [diff] [review]
Patch v1
r=me, fwiw.
PS: It's l[ocalizatio]n, "oclizatio" being 10 chars, thus l10n (no i). And now you know ;-)
Attachment #467104 -
Flags: review+
|
||
Updated•14 years ago
|
Attachment #467104 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #4)
> PS: It's l[ocalizatio]n, "oclizatio" being 10 chars, thus l10n (no i). And now
> you know ;-)
Ahh, I was wondering what's the 10 is for. Thanks for let me know and for setting r+ on this bug :)
PS: You're quick!
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Attachment #467104 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Summary: Fix i10n comments for JS/DOM Object Introspector → Fix l10n comments for JS/DOM Object Introspector
|
||
Updated•14 years ago
|
Attachment #467104 -
Flags: approval2.0? → approval2.0+
|
||
Comment 6•14 years ago
|
||
|
|
||
Updated•14 years ago
|
Target Milestone: --- → Firefox 4.0b5
|
||
Updated•14 years ago
|
blocking2.0: ? → -
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•