Closed
Bug 588412
Opened 14 years ago
Closed 14 years ago
do not offer Firefox 4 Beta 4 updates to PPC users
Categories
(AUS Graveyard :: General, defect)
Tracking
(blocking2.0 beta4+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta4+ |
People
(Reporter: beltzner, Assigned: morgamic)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
nthomas
:
review+
|
Details | Diff | Splinter Review |
In bug 587799 we broke PPC builds for beta 4. No biggie, I don't think we have a lot of beta testers there, but we shouldn't offer updates to Firefox 4 Beta channel users as it will break their face.
Comment 1•14 years ago
|
||
Does the update query differentiate between Intel and PPC builds ?
https://aus2.mozilla.org/update/3/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
The %BUILD_TARGET% is Darwin_Universal-gcc3 in both cases. So it's OS_VERSION or bust ? Bug 552924 addresses this, but not for builds that are already in the wild.
Failing that, perhaps we can redirect based on the UA ? I have
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3) Gecko/20100805 Firefox/4.0b3
Reporter | ||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Does the update query differentiate between Intel and PPC builds ?
> https://aus2.mozilla.org/update/3/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
>
> The %BUILD_TARGET% is Darwin_Universal-gcc3 in both cases. So it's OS_VERSION
> or bust ? Bug 552924 addresses this, but not for builds that are already in the
> wild.
I was under the impression the query differentiated, but as you say, we may need to go off of UA string.
How does metrics get the info? UA?
Comment 3•14 years ago
|
||
CC'ing Metrics people.
What about those of us who use the PPC build? A lot of institutions will continue to use PPC machines for a long time. Users tend to use a machine until it breaks, developers tend to use cutting edge machines. Yes, not many Beta testers use PPC machines, but most Beta testers are developers, most PPC users will only use production releases. There is a population of users who would like FF 4 to continue working on PPC machines.
Comment 5•14 years ago
|
||
We (metrics) don't know how to differentiate a Intel from a PPC machine - unfortunately
Reporter | ||
Comment 6•14 years ago
|
||
(In reply to comment #4)
> What about those of us who use the PPC build? A lot of institutions will
This really isn't on-topic for this bug. Right now Beta 4 is broken for PPC, period. We shouldn't offer updates to it. That's all we're talking about.
Reporter | ||
Comment 7•14 years ago
|
||
(In reply to comment #5)
> We (metrics) don't know how to differentiate a Intel from a PPC machine -
> unfortunately
Well, we presently put it in the UA string:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8
The bit there that says "Intel Mac OS X 10.6" would say "PPC Mac OS ..."
Updated•14 years ago
|
blocking2.0: --- → ?
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•14 years ago
|
||
We'll have to make it dirty, but it's possible. Something along the lines of:
if (UA has 'PPC' && appVersion=? && channel=?) { don't do updates }
What version and channel are we looking for? v=4.0b3, channel=betatest?
Assignee | ||
Comment 10•14 years ago
|
||
This will offer no updates for any 4.0b3 clients with PPC in the UA string. Needs testing.
Attachment #468495 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #468495 -
Flags: review? → review?(nrthomas)
Comment 11•14 years ago
|
||
beltzner, which of these do you want ?
a) Intel: all versions --> 4.0b4
PPC: no update, stick with whatever you have
b) Intel: old version --> 4.0b3 --> 4.0b4
PPC: old version --> 4.0b3
a) can be done by blocking PPC in the UA for incoming version 3.7* or 4.0b*, and use the snippets we already have. Channels in use are betatest & releasetest (QA), and beta (end users) - we don't need different behaviour per channel
b) can be done by blocking PPC in the UA for incoming version 4.0b3, and doing the snippets differently (only pushing b3->b4 updates).
If PPC is getting dropped anyway then I'd advocate a) as simpler for RelEng and no-retesting for QA.
Reporter | ||
Comment 12•14 years ago
|
||
I want (a) - simplest and easiest. We haven't made the final call on PPC, but it is not likely long for this world.
Comment 13•14 years ago
|
||
Comment on attachment 468495 [details] [diff] [review]
v1, adds workaround, but not pretty
Guess we need wildcard matching on 3.7a* and 4.0b* then. Otherwise looks good.
Attachment #468495 -
Flags: review?(nrthomas) → review-
Assignee | ||
Comment 14•14 years ago
|
||
Ewww. Just what I wanted - regexes. :\
Attachment #468495 -
Attachment is obsolete: true
Attachment #468530 -
Flags: review?(nrthomas)
Comment 15•14 years ago
|
||
Comment on attachment 468530 [details] [diff] [review]
v2, adds expressions, thus creating mo' problems
>Index: index.php
>+if ( $clean['product'] == 'Firefox'
>+ && preg_match($clean['version'], '/^4\.0.+/')
>+ && preg_match($clean['version'], '/^3\.7.+/')
r+ if we match on 3.7 OR 4.0, and /^4\.0.*/ so that we block PPC updates when '4.0' comes along (with PPC support likely dropped).
Attachment #468530 -
Flags: review?(nrthomas) → review+
Assignee | ||
Comment 16•14 years ago
|
||
Right, covers 4.0$ case and also makes this an OR. AND would have no matches since you can only have on version at a time!
Attachment #468537 -
Flags: review?(nrthomas)
Assignee | ||
Comment 17•14 years ago
|
||
Attachment #468530 -
Attachment is obsolete: true
Attachment #468537 -
Attachment is obsolete: true
Attachment #468548 -
Flags: review?(nrthomas)
Attachment #468537 -
Flags: review?(nrthomas)
Assignee | ||
Comment 18•14 years ago
|
||
v4 checked in based on tests and r=nthomas. We're testing it in staging right now.
Checking in index.php;
/cvsroot/mozilla/webtools/aus/xml/index.php,v <-- index.php
new revision: 1.28; previous revision: 1.27
done
Comment 19•14 years ago
|
||
I performed the following set of tests:
PPC Machine:
Downloaded a fresh copy of Firefox 4 B3 from the releases directory.
Connected to the MPT
Changed to the staging URL-> http://aus2-staging.mozilla.org/
Confirmed that I was connected to the server
Help->Check for Updates
No update found
Downloaded a fresh copy of FF 3.6.7 from the releases directory
Connected to the MPT
Changed to the staging URL-> http://aus2-staging.mozilla.org/
Confirmed that I was connected to the server
Help->Check for Updates
Update to 3.6.8 found
Intel:
Downloaded a fresh copy of FF 4 Beta 3
Changed the channel to betatest
Connected to the MPT
Changed to the staging URL-> http://aus2-staging.mozilla.org/
Confirmed that I was connected to the server
Help->Check for Updates
Update to Beta 4 found
Assignee | ||
Comment 20•14 years ago
|
||
Thanks so much Marcia. I'll file push bug for prod.
Assignee | ||
Comment 21•14 years ago
|
||
This was pushed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Attachment #468548 -
Flags: review?(nrthomas) → review+
Reporter | ||
Comment 22•14 years ago
|
||
Thanks everyone. Super awesome!
Reporter | ||
Comment 23•14 years ago
|
||
This will still block updates for beta 5, right?
Comment 24•14 years ago
|
||
Yes, any version matching 4.0* or 3.7*.
You need to log in
before you can comment on or make changes to this bug.
Description
•