Closed
Bug 588690
Opened 14 years ago
Closed 14 years ago
Clear graphics resources of inactive windows
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta5+ |
People
(Reporter: bas.schouten, Assigned: bas.schouten)
Details
Attachments
(2 files)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The BasicLayerManager can hold on to several graphics resources. We should clear those out when a window is hidden or destroyed to conserve memory.
Attachment #467312 -
Flags: review?(roc)
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #467313 -
Flags: review?(roc)
Comment on attachment 467312 [details] [diff] [review]
Part 1: Expose ClearCachedResources from BasicLayerManager
+ /**
+ * Layers will get this call when their layer manager is destroyed, this
+ * indicates they should clear resources they don't really need after their
+ * LayerManager ceases to exist.
+ */
+ virtual void ClearResources() {}
Call this ClearCachedResources and adjust comment to fit.
+ for (Layer* child = aLayer->GetFirstChild(); child;
+ child = child->GetNextSibling()) {
+ ClearLayer(child);
Fix indent
Attachment #467312 -
Flags: review?(roc) → review+
Attachment #467313 -
Flags: review?(roc) → review+
blocking2.0: --- → beta5+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8c767b950381
http://hg.mozilla.org/mozilla-central/rev/2f75f983440c
http://hg.mozilla.org/mozilla-central/rev/9976121e4d31
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•