In bug 568634 I add a xul:textNodes to an existing xul:label in the WebConsole. This new insert node makes the this.outputNode.addEventListener("DOMNodeInserted", function(ev) { throw an error (taken from an unit test): TEST-INFO | chrome://mochikit/content/browser/toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js | Console message: [JavaScript Error: "ev.target.classList is undefined" {file: "resource://gre/modules/HUDService.jsm" line: 2265}] TextNodes doesn't have a classList object (== undefined) and therefore the check line 2265: if (ev.target.classList.contains("hud-msg-node")) { failes.

Patch attached.

Patrick, I haven't tried the patch but it looks good from just reading the code. This is not part of this bug, but if a new textNode is insert, the parent node of the textNode should get checked in case it matches the filtering rules or not. Imagine a label has the text "foo" and filtering is set to "bar". The "foo"-label is not visible. Now the string "baring" is added to the "foo"-label. This now matches the search string "bar" and the "foo"-label should show up. Do you want me to fill a separate bug on that?

(In reply to comment #1) > Created attachment 467949 [details] [diff] [review] > Proposed patch. > > Patch attached. Patrick, I included your patch into my repo without the fix so that only the unit tests run. They passed although I could see some Console message: [JavaScript Error: "ev.target.classList is undefined" {file: "resource://gre/modules/HUDService.jsm" line: 3005}] which means that the unit test doesn't work. I tried to figure out why the unit test is not working (adding the textNode after a timeout of 1 sec and see if an error occurred) but I couldn't. Let's discuss this later.

This patch is based on Patrick's submission with some modifications that should make the unit test fail - but they don't. Patrick, can you reproduce that this isn't failing?

New patch attached. Unit tests seem to pass on my machine; try is borked due to bug 591074 so I can't be 100% confident at this point.

(In reply to comment #5) > Created attachment 469643 [details] [diff] [review] > Proposed patch, version 2. > > New patch attached. Unit tests seem to pass on my machine; try is borked due to > bug 591074 so I can't be 100% confident at this point. Do you have a windows build and linux build to try it out on? I think we should all have them at this point:(

Patch rebased to trunk.

This bug is blocking blockers (some even designated as beta5+)

Comment on attachment 469696 [details] [diff] [review] Proposed patch, version 2.1. This patch looks fine to me. As far as I know the listener in the test code does not need to be an object with the observe method. I think you can directly pass the function. (this works with the observer service - might work with the console service listeners as well) Also, you manually get the nsIConsoleService component. You should get it much quicker with Services.console from Services.jsm.