Closed
Bug 588871
Opened 14 years ago
Closed 13 years ago
Remove ConsoleStorage methods used for log message storage
Categories
(DevTools :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 703235
People
(Reporter: ddahl, Assigned: ddahl)
References
Details
(Whiteboard: [console-1])
Attachments
(1 file)
|
(deleted),
patch
|
johnath
:
approval2.0-
|
Details | Diff | Splinter Review |
We are moving all storage over to the ConsoleStorageService now, so we can use the ConsoleStorage object for config/filtering prefs only now - as well as other things that might come up in the future.
We should also rename this object. Let the bikeshedding begin!
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → ddahl
|
||
Comment 1•14 years ago
|
||
ConsoleConfig?
Whatever, we need not spend much time on the naming given that it's just an internal component for the Web Console.
Whiteboard: [kd4b5]
|
|
||
Updated•14 years ago
|
Whiteboard: [kd4b5] → [kd4b7]
|
|
||
Updated•14 years ago
|
Whiteboard: [kd4b7]
|
|
Assignee | |
Comment 2•14 years ago
|
||
This is a followup to all of the ConsoleStorageService bugs. This is purely code removal and will affect perf and memory use in a GOOD way:)
Attachment #499160 -
Flags: review?(dietrich)
Attachment #499160 -
Flags: approval2.0?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 499160 [details] [diff] [review]
v 0.1 Code removal Patch
Can't approve without review.
Attachment #499160 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [console-1]
|
||
Comment 4•14 years ago
|
||
Is this rotted or still needing review?
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 499160 [details] [diff] [review]
v 0.1 Code removal Patch
I will need to unbitrot this and remove some clutter
Attachment #499160 -
Flags: review?(dietrich)
|
||
Comment 6•13 years ago
|
||
This is a console cleanup bug. Some day we should complete this patch. The ConsoleStorage object in HUDService is not very much needed, actually. We can handle prefs in a better way.
Blocks: consolecleanup
|
||
Comment 7•13 years ago
|
||
This will be fixed by my patch on bug 703235 .
|
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•