Closed Bug 589400 Opened 14 years ago Closed 14 years ago

two small fixes to talos harness

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tnikkel, Unassigned)

References

Details

Attachments

(2 files)

Running standalone talos I came across two things. I don't know where these files live in version control, so I'll just attach a raw diff.
Not sure who I should be asking for review. When I made some changes to the pageloader extension and zipped them up and replaced the xpi I got an error here with a directory already existing. I think this is due to the order of the files in the zip changing. We just need to check for the existence of the directory before creating it.
Attachment #468012 - Flags: review?(anodelman)
Not sure of who to ask for review. There is no pageloader.css so we should stop trying to load it.
Attachment #468013 - Flags: review?(anodelman)
Attachment #468012 - Flags: review?(anodelman) → review+
Attachment #468013 - Flags: review?(anodelman) → review+
Note that the attached diffs are between file and file.orig, so some manual intervention will be required.
The copy of pageloader.xpi user by talos machines will also have to be updated (after the check in, of course).
Comment on attachment 468012 [details] [diff] [review] [checked in] check for existence of dir before trying to create it Landed: Checking in ffsetup.py; /cvsroot/mozilla/testing/performance/talos/ffsetup.py,v <-- ffsetup.py new revision: 1.22; previous revision: 1.21 done
Attachment #468012 - Attachment description: check for existence of dir before trying to create it → [checked in] check for existence of dir before trying to create it
I'm not certain where to apply this pageloader.xul patch. It's in CVS, m-c, 1.9.2, tracemonkey, et. al. I don't know what to do with, so that part isn't making the downtime.
Is this still waiting on landing the pageloader change?
Looks like it.
Comment on attachment 468013 [details] [diff] [review] [checked in]stop refering to non-existent css file changeset: 3:eab9ffc922b1
Attachment #468013 - Attachment description: stop refering to non-existent css file → [checked in]stop refering to non-existent css file
Depends on: 609922
Sorry for the long delay here, I'll make sure that it gets correctly landed.
Thank you Alice!
So this is all finished now?
Everything is landed now. All done.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: