Closed
Bug 589400
Opened 14 years ago
Closed 14 years ago
two small fixes to talos harness
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tnikkel, Unassigned)
References
Details
Attachments
(2 files)
(deleted),
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
Running standalone talos I came across two things. I don't know where these files live in version control, so I'll just attach a raw diff.
Reporter | ||
Comment 1•14 years ago
|
||
Not sure who I should be asking for review.
When I made some changes to the pageloader extension and zipped them up and replaced the xpi I got an error here with a directory already existing. I think this is due to the order of the files in the zip changing. We just need to check for the existence of the directory before creating it.
Attachment #468012 -
Flags: review?(anodelman)
Reporter | ||
Comment 2•14 years ago
|
||
Not sure of who to ask for review.
There is no pageloader.css so we should stop trying to load it.
Attachment #468013 -
Flags: review?(anodelman)
Updated•14 years ago
|
Attachment #468012 -
Flags: review?(anodelman) → review+
Updated•14 years ago
|
Attachment #468013 -
Flags: review?(anodelman) → review+
Reporter | ||
Comment 3•14 years ago
|
||
Note that the attached diffs are between file and file.orig, so some manual intervention will be required.
Comment 4•14 years ago
|
||
The copy of pageloader.xpi user by talos machines will also have to be updated (after the check in, of course).
Comment 5•14 years ago
|
||
Comment on attachment 468012 [details] [diff] [review]
[checked in] check for existence of dir before trying to create it
Landed:
Checking in ffsetup.py;
/cvsroot/mozilla/testing/performance/talos/ffsetup.py,v <-- ffsetup.py
new revision: 1.22; previous revision: 1.21
done
Updated•14 years ago
|
Attachment #468012 -
Attachment description: check for existence of dir before trying to create it → [checked in] check for existence of dir before trying to create it
Comment 6•14 years ago
|
||
I'm not certain where to apply this pageloader.xul patch. It's in CVS, m-c, 1.9.2, tracemonkey, et. al. I don't know what to do with, so that part isn't making the downtime.
Comment 7•14 years ago
|
||
Is this still waiting on landing the pageloader change?
Reporter | ||
Comment 8•14 years ago
|
||
Looks like it.
Comment 9•14 years ago
|
||
Comment on attachment 468013 [details] [diff] [review]
[checked in]stop refering to non-existent css file
changeset: 3:eab9ffc922b1
Attachment #468013 -
Attachment description: stop refering to non-existent css file → [checked in]stop refering to non-existent css file
Comment 10•14 years ago
|
||
Sorry for the long delay here, I'll make sure that it gets correctly landed.
Reporter | ||
Comment 11•14 years ago
|
||
Thank you Alice!
Reporter | ||
Comment 12•14 years ago
|
||
So this is all finished now?
Comment 13•14 years ago
|
||
Everything is landed now. All done.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•