Closed
Bug 589606
Opened 14 years ago
Closed 14 years ago
No --disable-raw option, and raw decoder not built if all other media types disabled
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: cpearce, Assigned: khuey)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
cpearce
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
There does not seems to be a --disable-raw build option. In fact it looks like raw video can't be disabled, and its configure section doesn't ensure MOZ_MEDIA is defined, so raw video will only be enabled when some other media type is enabled and that sets MOZ_MEDIA. i.e. If we build with --disable-wave, --disable-webm, and --disable-ogg, despite the fact that MOZ_RAW will still be defined, and the pref media.raw.enabled will be true, raw support won't be built because MOZ_MEDIA isn't defined.
There should be a --disable-raw option, and if raw video is not disabled, its configure section should ensure MOZ_MEDIA is defined, like the other media types' configure sections.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → khuey
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #469031 -
Flags: review?(chris)
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 469031 [details] [diff] [review]
Patch
Great, thanks!
Attachment #469031 -
Flags: review?(chris) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 469031 [details] [diff] [review]
Patch
Trivial build only consistency fix. We should take this for 2.0.
Attachment #469031 -
Flags: approval2.0?
|
||
Comment 4•14 years ago
|
||
Comment on attachment 469031 [details] [diff] [review]
Patch
a=sdwilsh
Attachment #469031 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
You need to log in
before you can comment on or make changes to this bug.
Description
•